Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 17 #113

Closed
wants to merge 1 commit into from
Closed

Update to React 17 #113

wants to merge 1 commit into from

Conversation

masone
Copy link

@masone masone commented Jun 25, 2021

addresses #101 where this library could not be used with React 17 because the peerDependencies are locked to v15/16.

npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.5.4 || ^16.0.0" from [email protected]
npm ERR! node_modules/react-tooltip-lite
npm ERR!   react-tooltip-lite@"*" from the root project

Reading through the changelog for React 17, I don't see breaking changes that should affect this project. I gave the codepen from the README a spin with the updated version and storybook looks fine and tests are passing too

is there anything else to be done? happy to further help with unlocking the upgrade 😄

@masone
Copy link
Author

masone commented Jun 29, 2021

@bsidelinger912 what do you think 😃

@masone masone mentioned this pull request Jul 2, 2021
@masone
Copy link
Author

masone commented Dec 12, 2021

ping @bsidelinger912

@buesing
Copy link

buesing commented Jan 6, 2022

@bsidelinger912 could we get this merged? The latest npm is throwing an error because of this dependency mismatch, even though everything is working. Is there anything else we can do to accelerate this?

@JurajKavka
Copy link

ping @bsidelinger912

@bsidelinger912
Copy link
Owner

Hey everyone, sorry for the terrible lag here. I'm guessing this is fine, but I'm not able to test ATM. Would anyone here be interested in taking over ownership of this project? It's been a good resume builder for me in the past, but all my free time these days is taken up by my four kids and I'm interested in handing this off.

@buesing
Copy link

buesing commented Feb 2, 2022

@bsidelinger912 hey, I can do that. Shoot me a mail to [email protected] and we can discuss transferring.

@josdejong
Copy link

Any news on this? Would be great to have support for React 17 and 18

@transfer1992
Copy link

Is this project dead?

@samiashi
Copy link

@bsidelinger912 @buesing Any updates on this?

@transfer1992
Copy link

We decided to rewrite to another library. I think this one is dead.

@masone masone closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants