-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to React 17 #113
Update to React 17 #113
Conversation
@bsidelinger912 what do you think 😃 |
ping @bsidelinger912 |
@bsidelinger912 could we get this merged? The latest npm is throwing an error because of this dependency mismatch, even though everything is working. Is there anything else we can do to accelerate this? |
ping @bsidelinger912 |
Hey everyone, sorry for the terrible lag here. I'm guessing this is fine, but I'm not able to test ATM. Would anyone here be interested in taking over ownership of this project? It's been a good resume builder for me in the past, but all my free time these days is taken up by my four kids and I'm interested in handing this off. |
@bsidelinger912 hey, I can do that. Shoot me a mail to [email protected] and we can discuss transferring. |
Any news on this? Would be great to have support for React 17 and 18 |
Is this project dead? |
@bsidelinger912 @buesing Any updates on this? |
We decided to rewrite to another library. I think this one is dead. |
addresses #101 where this library could not be used with React 17 because the
peerDependencies
are locked to v15/16.Reading through the changelog for React 17, I don't see breaking changes that should affect this project. I gave the codepen from the README a spin with the updated version and storybook looks fine and tests are passing too
is there anything else to be done? happy to further help with unlocking the upgrade 😄