[frontend] Fix bugs in maxpool2d_simplify and rename MaxPool2dOp for clarity #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanghb97
reviewed
Jul 9, 2024
| @@ -63,4 +74,4 @@ def maxpool2d_simplify(graph: Graph): | |||
| for j, op in enumerate(graph.body): | |||
| if op == getitem_node: | |||
| graph.body[j] = new_node | |||
| break | |||
| break | |||
There was a problem hiding this comment.
Please do not remove the empty line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxpool2d_simplifyfunction inuseless_op_eliminate.py.max2dpoolOpto a more intuitive name for better clarity.