Close file on creation (#76)

bugdea1er · Jun 20, 2024 · ed100c8 · ed100c8
1 parent a46c406
commit ed100c8
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/tmp.cpp b/src/tmp.cpp
@@ -92,11 +92,19 @@ fs::path create_file(std::string_view prefix, std::string_view suffix) {
         }
 
         ec = std::error_code(err, std::system_category());
+    } else {
+        CloseHandle(file);
     }
+
 #else
-    if (mkstemps(path.data(), static_cast<int>(suffix.size())) == -1) {
+    const int fileDescriptor =
+        mkstemps(path.data(), static_cast<int>(suffix.size()));
+    if (fileDescriptor == -1) {
         ec = std::error_code(errno, std::system_category());
+    } else {
+        close(fileDescriptor);
     }
+
 #endif
     if (ec) {
         throw fs::filesystem_error("Cannot create temporary file", ec);