Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmp::entry::move behaviour is inconsistent and not documented #113

Closed
bugdea1er opened this issue Sep 15, 2024 · 0 comments · Fixed by #129
Closed

tmp::entry::move behaviour is inconsistent and not documented #113

bugdea1er opened this issue Sep 15, 2024 · 0 comments · Fixed by #129

Comments

@bugdea1er
Copy link
Owner

In v1.0 tmp::entry::move unconditionally deletes the target path before moving, but only moving between different filesystems:

tmp/src/entry.cpp

Line 78 in 0c6a0b1

fs::remove_all(to);

Move should behave like std::filesystem::rename and std::filesystem::copy
@bugdea1er bugdea1er linked a pull request Oct 8, 2024 that will close this issue
Fix tmp::entry::move method #129
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tmp::entry::move method bugdea1er/tmp
1 participant
@bugdea1er