Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tmp::entry::move method #129

Merged
merged 32 commits into from
Oct 13, 2024
Merged

Fix tmp::entry::move method #129

merged 32 commits into from
Oct 13, 2024

Conversation

bugdea1er
Copy link
Owner

@bugdea1er bugdea1er commented Oct 8, 2024 •
edited
Loading

  • Fix a bug when moving an entry to itself caused a deletion of said entry
  • Fix a bug when moving a directory to an existing file between filesystems would not throw an exception
  • Fix a bug when move was constrained to regular files and directories only
  • Fix a bug when an entry could be deleted even if it was not moved due to an error
  • Add a lot of tests
  • Explain the entry::move behaviour somewhat better

@bugdea1er bugdea1er linked an issue Oct 8, 2024 that may be closed by this pull request
tmp::entry::move behaviour is inconsistent and not documented #113
Closed
@bugdea1er
Test GitHub Actions configuration
55e888d
@bugdea1er
Remove debug printing
baa5c5a
@bugdea1er
Remove more debug prints
09161d1
@bugdea1er
Do not explicitly initialize paths where not needed
67adc6a
@bugdea1er
Remove managed path only when moving between devices
0b0127b
@bugdea1er
Add tests for entry::move to itself
5605b16
@bugdea1er
Add test for move overwriting
2883088
@bugdea1er
Add a test for moving a file to a non-existing path
abbe800
@bugdea1er
Add a test for moving a file to an existing directory
330eeba
@bugdea1er
Tidy up includes
af277ea
@bugdea1er
Add a test for moving a file to a non-existing directory
f7bf048
@bugdea1er
Fix clang-tidy warnings
a23f1cf
@bugdea1er
Add tests for moving to existing paths
5692798
@bugdea1er
Test moving a directory to a non-existing path
d806b32
@bugdea1er
Fix a bug when moving a directory to an existing file between devices
e59edf4
@bugdea1er
Expand the documentation for entry::move
b4a2ca7
@bugdea1er
Close file streams after reading contents
d21978d
@bugdea1er
Check file types before renaming in entry::move
c03415e
@bugdea1er
Fix test specially for Windows
6050b45
@bugdea1er
Actually Windows behaves the same here
7a32f91
@bugdea1er
Fix from is_regular_file to !is_directory
3f5317a
@bugdea1er
Fix Windows specific rename behaviour
c5190e2
@bugdea1er
Maybe clashing names is the problem?
8bb39f5
@bugdea1er
Fix test files cleanup
23fa6c2
@bugdea1er
Fix tests on Windows
e565443
@bugdea1er
Define one error value for a platform
999bacc
@bugdea1er
Fix Windows platform macro usage
c9c5352
@bugdea1er bugdea1er marked this pull request as ready for review October 13, 2024 19:29
@bugdea1er bugdea1er merged commit 8d5e1dd into main Oct 13, 2024
9 checks passed
@bugdea1er bugdea1er deleted the 113-move-behaviour branch October 13, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tmp::entry::move behaviour is inconsistent and not documented
1 participant
@bugdea1er