Refactor @bugsnag/browser #2252
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerbenw
force-pushed
the
PLAT-12163/browser
branch
from
a04fe2c to
1b9a68e
Compare
gingerbenw
force-pushed
the
PLAT-12163/browser
branch
from
a881ec2 to
5519d06
Compare
gingerbenw
force-pushed
the
integration/typescript
branch
from
9a4591e to
7bbbff9
Compare
gingerbenw
force-pushed
the
PLAT-12163/browser
branch
from
5519d06 to
08a3dc9
Compare
gingerbenw
force-pushed
the
PLAT-12163/browser
branch
from
08a3dc9 to
8c78faf
Compare
djskinner
reviewed
Dec 11, 2024
| @@ -49,7 +49,9 @@ module.exports = { | |||
| 'plugin-simple-throttle', | |||
| 'plugin-console-breadcrumbs', | |||
| 'plugin-browser-session' | |||
| ]), | |||
| ], { | |||
| setupFiles: ['<rootDir>/jest/setup/mockEventTarget.js'] | |||
There was a problem hiding this comment.
See jsdom/jsdom#2156
This is needed to fix the TypeError: 'addEventListener' called on an object that is not a valid instance of EventTarget. seen in the integration tests following the rollup changes
added 2 commits
December 11, 2024 16:00
djskinner
reviewed
Dec 16, 2024
packages/browser/package.json
Outdated
Comment on lines
34
to
35
| "build:dist": "cross-env NODE_ENV=production bash -c '../../bin/bundle src/notifier.js --standalone=Bugsnag | ../../bin/extract-source-map dist/bugsnag.js'", | ||
| "build:dist:min": "cross-env NODE_ENV=production bash -c '../../bin/bundle src/notifier.js --standalone=Bugsnag | ../../bin/minify dist/bugsnag.min.js'", |
There was a problem hiding this comment.
yep - and possibly the minification scripts, too?
added 17 commits
December 19, 2024 11:15
djskinner
reviewed
Dec 23, 2024
| @@ -52,7 +52,7 @@ describe('browser notifier', () => { | |||
| load: client => 10 | |||
| }] | |||
| }) | |||
| expect(Bugsnag.getPlugin('foobar')).toBe(10) | |||
| expect(Bugsnag.getPlugin?.('foobar')).toBe(10) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR converts the last of the internal browser plugins and the browser client to TypeScript, using Rollup to bundle both common js and es modules
Following this work, we can then validate a flattened module (fesm) with a modern angular app
Design
Changeset
Testing
Existing test suite