Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include arm64 artifacts in release #680

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

imjasonh
Copy link
Member

@imjasonh
Copy link
Member Author

@natalieparellano rebased, and verified in my fork: https://github.com/imjasonh/lifecycle/releases/tag/v0.0.15

@natalieparellano
Copy link
Member

@imjasonh I am sorry to ask you to rebase again, but is it possible you could fix the merge conflicts in draft-release.yml? It should be as simple as updating the guards here and here - I think the other changes could be discarded since the arm artifacts will get pulled in automatically if they start with lifecycle-.

@natalieparellano
Copy link
Member

@imjasonh I took the liberty of resolving the conflicts so that we could move forward with the release (that includes the arm binaries!). I hope it's okay!

@imjasonh
Copy link
Member Author

imjasonh commented Sep 1, 2021

@imjasonh I took the liberty of resolving the conflicts so that we could move forward with the release (that includes the arm binaries!). I hope it's okay!

No worries! I'm actually out of the office for another week or so, so do whatever you have to do. If there's anything left when I get back I'm happy to do it. 😄

@natalieparellano
Copy link
Member

Tested on fork: https://github.com/natalieparellano/lifecycle/releases/tag/v0.901.0

On an arm machine:

# docker run natalieparellano/lifecycle:0.901.0-linux-arm64 /cnb/lifecycle/lifecycle -version
0.901.0+e2522ec4

@natalieparellano natalieparellano merged commit 3a6fd83 into buildpacks:main Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants