-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include arm64 artifacts in release #680
Conversation
@natalieparellano rebased, and verified in my fork: https://github.com/imjasonh/lifecycle/releases/tag/v0.0.15 |
Signed-off-by: Jason Hall <[email protected]>
@imjasonh I am sorry to ask you to rebase again, but is it possible you could fix the merge conflicts in draft-release.yml? It should be as simple as updating the guards here and here - I think the other changes could be discarded since the arm artifacts will get pulled in automatically if they start with |
@imjasonh I took the liberty of resolving the conflicts so that we could move forward with the release (that includes the arm binaries!). I hope it's okay! |
No worries! I'm actually out of the office for another week or so, so do whatever you have to do. If there's anything left when I get back I'm happy to do it. 😄 |
Tested on fork: https://github.com/natalieparellano/lifecycle/releases/tag/v0.901.0 On an arm machine:
|
I've tested this in my fork: https://github.com/imjasonh/lifecycle/releases/tag/v0.0.8
My fork pushed images to ghcr.io instead of Dockerhub: https://github.com/imjasonh/lifecycle/pkgs/container/lifecycle
cc @natalieparellano
#435