Changes of joacmue #14
Conversation
|
Hi @ulfgebhardt, Not sure what I'm getting myself into by becoming a maintainer, but I'd be open to contribute. |
|
Looking over the other current activities, this one mainly fixes lawdown and adds some image/table features to it (my test case was the StVO which is pretty heavy on images in tables for Traffic Signs and stuff). Might only want to review the changes to lawdown and readme.md and just throw away the other changes. |
|
Hey @joacmue nice to hear from you. I believe I could incite some activity into the project lately. I was informed that you made some nice changes not to long ago and just wanted to expose those to this repo. Would you be interested i contributing? I believe we are on a good way to get things running and have an up to date https://github.com/bundestag/gesetze repo soon. With your help sooner and better <3 With the looming Election this year having the repo up to date would save me from millions of questions why its not up to date ;) |
Still having issues with lawdown and pathlib
|
So, I just rebased my fork to what happened here but did not get the whole pathlib stuff right away, so most of the changes made there might have gotten lost. Feel free to add them back during the review. |
|
So I just recognized the bigger picture of pushing the actual laws to https://github.com/bundestag/gesetze That puts the work here in a new perspective for me. please stand by while I process this. |
|
I believe we have to copy the PR into the repo or rebase in oder for the tests to run. I cannot accept your suggestions. I think only @joacmue can, since hes the owner of the fork. |
|
@ulfgebhardt We should give @joacmue some time to work on this... |
- Fixed string types - Fixed bug where table rows started with a space character - Fixed bug where new folders where not created multi-level - Fixed unimplemented option --no-yaml
Putting the content somehow in the middle
Strangely, round(0.5) yields 0 but round(1.5) yields 2? Replaced with floor and ceil, importing them from math
Had a typo in parsing for the thead state -.-
Added it to a check in the end
There is room for improvement on rendering nested tables, I'm sure
Actually keping track of which column has entries now thereby printing later additions below earlier ones even for colspans
Had to run bgbl_scraper in between - updated that in readme.md
|
So, I rebased to the master from here. lawdown.py still works on everything wth the expected results, so I guess I made that right. However, I noticed that the banz_scraper fails with an error. I copied over the code from master here and I do have the same error, so I guess there's some fault in the code there. Not gonna put cleaning that up in this PR, though ;) |
|
Tables look good now 👍 Thanks for your great work so far! I resolved all comments which are good now and commented on the remaining ones. Especially the regression mentioned in #14 (comment) should be resolved before merging IMHO. |
|
Can't we make Issues for the remainign Issues and merge? This PR is way to big already |
|
Any update on this? |
Hey @joacmue
would you be interested in getting your changes in the master?
Would that be applicable?
Interested in becoming a maintainer?