Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run reference tests in CI #358

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mrc0mmand
Copy link
Contributor

Let's finish the reference tests saga and make use of installed reference tests ([0]) provided by a recently introduced dbus-broker-tests package ([1]).

This commit introduces a simple test that runs the reference tests (and benchmarks) against both dbus-daemon and dbus-broker.

[0] #351
[1] https://src.fedoraproject.org/rpms/dbus-broker/pull-request/14

Let's finish the reference tests saga and make use of installed
reference tests ([0]) provided by a recently introduced
dbus-broker-tests package ([1]).

This commit introduces a simple test that runs the reference tests (and
benchmarks) against both dbus-daemon and dbus-broker.

[0] bus1#351
[1] https://src.fedoraproject.org/rpms/dbus-broker/pull-request/14
@mrc0mmand mrc0mmand force-pushed the run-reference-tests branch from 876ff22 to b3b4d97 Compare April 16, 2024 20:06
@mrc0mmand mrc0mmand marked this pull request as ready for review April 16, 2024 20:38
@mrc0mmand
Copy link
Contributor Author

Everything seems to be working fine. The only test combination that's currently skipped is bench-message with dbus-daemon, since it takes an ungodly amount of time (over 13 minutes compared to just ~32 seconds with dbus-broker). Not sure if we want to slow down our CI with that.

@dvdhrm
Copy link
Member

dvdhrm commented Apr 17, 2024

bench-message installs up to half a million match rules and then measures message transactions. dbus-daemon iterates match-rules linearly, and might thus take a lot of time to perform this benchmark.

There might be another reason for it being slow, but this strikes me as the likely cause. We can also skip the test directly in bench-message.c, just like we do in test-fdstream.c.

@mrc0mmand
Copy link
Contributor Author

I thought about skipping bench-message directly, but there's nothing wrong with - the benchmark work just fine, it's just horribly slow. But I really have no preference here, either way works just fine for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants