Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more sistalk monsterpub devices and sensors for them #651

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

anon1im
Copy link

@anon1im anon1im commented Jul 27, 2024

Added a few devices that I own and could reverse engineer

Tested with intiface-engine and a python script.

I wanted to add subscriptions to newly added sensors, but couldn't find any mention of SensorSubscribeCmd in buttplug-device-config-v3.yml

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2024

CLA assistant check
All committers have signed the CLA.

@anon1im anon1im changed the base branch from master to dev July 27, 2024 09:10
@blackspherefollower
Copy link
Collaborator

Exactly which devices did you test? The config updates suggest pressure sensors on devices I'm fairly certain do not have them.

@anon1im
Copy link
Author

anon1im commented Jul 27, 2024

There is "Monster Pub 2 Premium Version" lineup, also called "Monster Pub Kegel" (here).

I have tested:

Dr. Whale Premium's pressure sensor works in official app and when using buttplug api

@blackspherefollower
Copy link
Collaborator

So, I think there's a bit of a translation issue somewhere: the MonsterPub devices (with a few exceptions) come in Whale, Devil and "Godzilla" not Godkilla.

The existing Whale 2 identifier was another model with pressure sensor. The new identifier should just be added to the existing configuration.

@blackspherefollower
Copy link
Collaborator

I suspect that the new identifier should have been noted on buttplugio/docs.buttplug.io#19 first

@anon1im
Copy link
Author

anon1im commented Jul 27, 2024

Naming is a mess: Godzilla is named as "Gokilla" and "Godkilla" on the same screen in the Monster Pub App.

Ok, I'll comment new info in the issue

@anon1im
Copy link
Author

anon1im commented Jul 27, 2024

Renamed Godkilla to Godzilla and merged "premium" Whale 2 with existing one.

Copy link
Collaborator

@blackspherefollower blackspherefollower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good start.
When I get back, I'll see if the battery readings can be more generalized across the entire brand.

I think longer term, pressure levels via subscription will be more useful, but I'm waiting for the next iteration of the sensor support in the Buttplug protocol before I was going to start looking into that seriously.

@qdot qdot force-pushed the dev branch 2 times, most recently from ca203ea to 110b302 Compare October 7, 2024 02:40
@qdot
Copy link
Member

qdot commented Dec 21, 2024

@blackspherefollower Where we at on this one?

@blackspherefollower
Copy link
Collaborator

It's probably fine. But I'll have time to test on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants