Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: return Webhook struct from WebhookEdit and WebhookEditWithToken #1497

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

Cyb3r-Jak3
Copy link
Contributor

Return *Webhook for WebhookEdit and WebhookEditWithToken.

Fixes #1495

@FedorLap2006 FedorLap2006 changed the title Return *Webhook for WebhookEdits fix!: return Webhook struct in WebhookEdit and WebhookEditWithToken Feb 16, 2024
@FedorLap2006 FedorLap2006 changed the title fix!: return Webhook struct in WebhookEdit and WebhookEditWithToken fix!: return Webhook struct from WebhookEdit and WebhookEditWithToken Feb 16, 2024
@FedorLap2006 FedorLap2006 merged commit 15ef2a4 into bwmarrin:master Feb 16, 2024
8 checks passed
@FedorLap2006 FedorLap2006 added fix Pull requests and issues related to bug fixes and structural inconsistencies breaking changes Contains breaking changes. Should be reflected in the changelog labels Feb 16, 2024
@FedorLap2006
Copy link
Collaborator

Thanks for noticing and fixing this!

@Cyb3r-Jak3 Cyb3r-Jak3 deleted the fix-webhook-returns branch February 16, 2024 14:11
ymotongpoo referenced this pull request in ymotongpoo/opentelemetry-collector-extra Jun 4, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/bwmarrin/discordgo](https://togithub.com/bwmarrin/discordgo)
| `v0.27.1` -> `v0.28.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fbwmarrin%2fdiscordgo/v0.28.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fbwmarrin%2fdiscordgo/v0.28.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fbwmarrin%2fdiscordgo/v0.27.1/v0.28.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fbwmarrin%2fdiscordgo/v0.27.1/v0.28.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>bwmarrin/discordgo (github.com/bwmarrin/discordgo)</summary>

###
[`v0.28.1`](https://togithub.com/bwmarrin/discordgo/releases/tag/v0.28.1):
DiscordGo v0.28.1

[Compare
Source](https://togithub.com/bwmarrin/discordgo/compare/v0.28.0...v0.28.1)

Hi all! This release, once again, only bumps semantic version of the
library and does not contain any new fixes nor features.
Sorry for the inconvenience! See previous release for changelog.

###
[`v0.28.0`](https://togithub.com/bwmarrin/discordgo/releases/tag/v0.28.0):
DiscordGo v0.28.0

[Compare
Source](https://togithub.com/bwmarrin/discordgo/compare/v0.27.1...v0.28.0)

##### Changelog

##### Breaking changes

- `ChannelEdit.Position` is now a pointer
[https://github.com/bwmarrin/discordgo/pull/1385](https://togithub.com/bwmarrin/discordgo/pull/1385)
- `Button.Emoji` is now a pointer
[https://github.com/bwmarrin/discordgo/pull/1475](https://togithub.com/bwmarrin/discordgo/pull/1475)
- `SelectMenuOption.Emoji` is now a pointer
[https://github.com/bwmarrin/discordgo/pull/1476](https://togithub.com/bwmarrin/discordgo/pull/1476)
- `Components` and `Embeds` in `MessageEdit` are now pointers
[https://github.com/bwmarrin/discordgo/pull/1483](https://togithub.com/bwmarrin/discordgo/pull/1483)
- `WebhookEdit` and `WebhookEditWithToken` now return `*Webhook`,
instead of `*Role`
[https://github.com/bwmarrin/discordgo/pull/1497](https://togithub.com/bwmarrin/discordgo/pull/1497)
- `AuditLogGuildScheduledEventUpdare` was renamed to
`AuditLogGuildScheduledEventUpdate`
[https://github.com/bwmarrin/discordgo/pull/1370](https://togithub.com/bwmarrin/discordgo/pull/1370)
- Type of `Message.StickerItems` was changed to `[]StickerItem`
[https://github.com/bwmarrin/discordgo/pull/1494](https://togithub.com/bwmarrin/discordgo/pull/1494)
- `withMember` parameter was added to `Session.ThreadMember` and
`Session.ThreadMembers`
[https://github.com/bwmarrin/discordgo/pull/1325](https://togithub.com/bwmarrin/discordgo/pull/1325)
- `limit` parameter was added to `Session.ThreadMembers`
[https://github.com/bwmarrin/discordgo/pull/1325](https://togithub.com/bwmarrin/discordgo/pull/1325)

##### Features

- Onboarding
[https://github.com/bwmarrin/discordgo/pull/1401](https://togithub.com/bwmarrin/discordgo/pull/1401)
- Default values for auto-populated select menus
[https://github.com/bwmarrin/discordgo/pull/1452](https://togithub.com/bwmarrin/discordgo/pull/1452)
- Role icons
[https://github.com/bwmarrin/discordgo/pull/1334](https://togithub.com/bwmarrin/discordgo/pull/1334)

##### Additions

- Add support for usernames without disciminator
[https://github.com/bwmarrin/discordgo/pull/1387](https://togithub.com/bwmarrin/discordgo/pull/1387)
- Add `WebhookParams.ThreadName`
[https://github.com/bwmarrin/discordgo/pull/1412](https://togithub.com/bwmarrin/discordgo/pull/1412)
- Add `SuppressNotification` and `IsVoiceMessage` message flags
[https://github.com/bwmarrin/discordgo/pull/1428](https://togithub.com/bwmarrin/discordgo/pull/1428)
- Add `MessageSend.Flags`
[https://github.com/bwmarrin/discordgo/pull/1427](https://togithub.com/bwmarrin/discordgo/pull/1427)
- Add `FailIfNotExists` and `SoftReference` to `Message`
[https://github.com/bwmarrin/discordgo/pull/1376](https://togithub.com/bwmarrin/discordgo/pull/1376)
- Add `MessageSend.StickerIDs`
[https://github.com/bwmarrin/discordgo/pull/1340](https://togithub.com/bwmarrin/discordgo/pull/1340)
- Add `ApplicationCommandInteractionData.CommandType`
[https://github.com/bwmarrin/discordgo/pull/1362](https://togithub.com/bwmarrin/discordgo/pull/1362)
- Add `AuditLogOptions.IntegrationType`
[https://github.com/bwmarrin/discordgo/pull/1440](https://togithub.com/bwmarrin/discordgo/pull/1440)
- Add `AuditLogOptions.ApplicationID`
[https://github.com/bwmarrin/discordgo/pull/1380](https://togithub.com/bwmarrin/discordgo/pull/1380)
- Add auto moderation audit log actions and options
[https://github.com/bwmarrin/discordgo/pull/1371](https://togithub.com/bwmarrin/discordgo/pull/1371)
- Add monetization audit log actions
[https://github.com/bwmarrin/discordgo/pull/1442](https://togithub.com/bwmarrin/discordgo/pull/1442)
- Add `BotHTTPInteractions` and `ActiveBotDeveloper` user flags
[https://github.com/bwmarrin/discordgo/pull/1465](https://togithub.com/bwmarrin/discordgo/pull/1465)
- Add `ThreadMember.Member`
[https://github.com/bwmarrin/discordgo/pull/1325](https://togithub.com/bwmarrin/discordgo/pull/1325)
- Add `Member.Flags`
[https://github.com/bwmarrin/discordgo/pull/1499](https://togithub.com/bwmarrin/discordgo/pull/1499)
- Add `Member.DisplayName`
[https://github.com/bwmarrin/discordgo/pull/1426](https://togithub.com/bwmarrin/discordgo/pull/1426)
- Add `Attachments` to `InteractionResponseData`, `WebhookEdit` and
`WebhookParams`
[https://github.com/bwmarrin/discordgo/pull/1392](https://togithub.com/bwmarrin/discordgo/pull/1392)
- Add `Session.ShouldReconnectVoiceOnSessionError`
[https://github.com/bwmarrin/discordgo/pull/1350](https://togithub.com/bwmarrin/discordgo/pull/1350)
- Add `Role.Flags`
[https://github.com/bwmarrin/discordgo/pull/1410](https://togithub.com/bwmarrin/discordgo/pull/1410)
- Add `UpdateCustomStatus`
[https://github.com/bwmarrin/discordgo/pull/1425](https://togithub.com/bwmarrin/discordgo/pull/1425)
- Add Spanish LATAM locale
[https://github.com/bwmarrin/discordgo/pull/1496](https://togithub.com/bwmarrin/discordgo/pull/1496)
- Add `GuildDirectory` and `GuildMedia` channel types
[https://github.com/bwmarrin/discordgo/pull/1514](https://togithub.com/bwmarrin/discordgo/pull/1514)

##### Other changes

- Fix error shadowing in `WebhookEditWithToken`
[https://github.com/bwmarrin/discordgo/pull/1372](https://togithub.com/bwmarrin/discordgo/pull/1372)
- Remove remove duplicated slash in `EndpointGuildTemplate`
[https://github.com/bwmarrin/discordgo/pull/1395](https://togithub.com/bwmarrin/discordgo/pull/1395)
- Fix incorrect `AuditLogOptionsType` values
[https://github.com/bwmarrin/discordgo/pull/1413](https://togithub.com/bwmarrin/discordgo/pull/1413)
- Allow `Components` and `Embeds` in `MessageEdit` to be set to `[]`
[https://github.com/bwmarrin/discordgo/pull/1483](https://togithub.com/bwmarrin/discordgo/pull/1483)
- Allow `ChannelEdit.Position` to be set to `0`
[https://github.com/bwmarrin/discordgo/pull/1385](https://togithub.com/bwmarrin/discordgo/pull/1385)
- Fix `BUTTON_COMPONENT_INVALID_EMOJI` error for `Button`
[https://github.com/bwmarrin/discordgo/pull/1475](https://togithub.com/bwmarrin/discordgo/pull/1475)
- Fix `BUTTON_COMPONENT_INVALID_EMOJI` error for `SelectMenuOption`
[https://github.com/bwmarrin/discordgo/pull/1476](https://togithub.com/bwmarrin/discordgo/pull/1476)

##### Special thanks

-   [@&#8203;Roolps](https://togithub.com/Roolps)
-   [@&#8203;tckthecreator](https://togithub.com/tckthecreator)
-   [@&#8203;quackduck](https://togithub.com/quackduck)
-   [@&#8203;Earlopain](https://togithub.com/Earlopain)
-   [@&#8203;loghinalexandru](https://togithub.com/loghinalexandru)
-   [@&#8203;merlinfuchs](https://togithub.com/merlinfuchs)
-   [@&#8203;Aldiwildan77](https://togithub.com/Aldiwildan77)
-   [@&#8203;Ju0x](https://togithub.com/Ju0x)
-   [@&#8203;JulienTant](https://togithub.com/JulienTant)
-   [@&#8203;KokeCacao](https://togithub.com/KokeCacao)
-   [@&#8203;SamusAranX](https://togithub.com/SamusAranX)
-   [@&#8203;TheGrandPackard](https://togithub.com/TheGrandPackard)
-   [@&#8203;phamill](https://togithub.com/phamill)
-   [@&#8203;AlexeyOplachko](https://togithub.com/AlexeyOplachko)
-   [@&#8203;Cyb3r-Jak3](https://togithub.com/Cyb3r-Jak3)
-   [@&#8203;joshuasing](https://togithub.com/joshuasing)
-   [@&#8203;hhaste](https://togithub.com/hhaste)

**Full Changelog**:
bwmarrin/discordgo@v0.27.1...v0.28.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ymotongpoo/opentelemetry-collector-extra).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODguMSIsInVwZGF0ZWRJblZlciI6IjM3LjM4OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes Contains breaking changes. Should be reflected in the changelog fix Pull requests and issues related to bug fixes and structural inconsistencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook functions return Role instead of Webhook
2 participants