Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remaining Windows filesystem functions #3166

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

zoraaver
Copy link
Contributor

Now that the filesystem implementation is now complete, the previous test filters on Windows can be removed. Some of the tests only pass when certain environment variables have been set on Windows so an extra step has been added in the wasi test runner script to modify the test config files before the tests begin.

@zoraaver zoraaver force-pushed the windows-filesystem branch 2 times, most recently from 31d0d65 to db5d928 Compare February 18, 2024 21:00
core/shared/platform/windows/win_file.c Outdated Show resolved Hide resolved
core/shared/platform/windows/win_file.c Outdated Show resolved Hide resolved
@wenyongh
Copy link
Contributor

@loganek Could you help review this PR? It should be in ready status, the CI failures are due to other issues and we are looking into them.

@@ -41,6 +41,12 @@ readonly THREAD_INTERNAL_TESTS="${WAMR_DIR}/core/iwasm/libraries/lib-wasi-thread
readonly THREAD_STRESS_TESTS="${WAMR_DIR}/core/iwasm/libraries/lib-wasi-threads/stress-test/"
readonly LIB_SOCKET_TESTS="${WAMR_DIR}/core/iwasm/libraries/lib-socket/test/"

add_env_key_to_test_config_file() {
filepath="tests/$2/testsuite/$3.json"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of modifying test files, could we perhaps extend the WAMR adapter and allow passing env variables through it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍 - this is a bit hacky

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the filesystem implementation is now complete, the previous
test filters on Windows can be removed. Some of the tests only pass when
certain environment variables have been set on Windows so an extra step
has been added in the wasi test runner script to modify the test config
files before the tests begin.
@wenyongh wenyongh merged commit 92bd3ba into bytecodealliance:main Feb 28, 2024
406 checks passed
@zoraaver zoraaver deleted the windows-filesystem branch February 28, 2024 10:25
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
…e#3166)

Now that the filesystem implementation is now complete, the previous
test filters on Windows can be removed. Some of the tests only pass when
certain environment variables have been set on Windows so an extra step
has been added in the wasi test runner script to modify the test config
files before the tests begin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants