ensure all fd closed #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 21, 2019 16:45
cakturk
reviewed
Jan 17, 2020
| if err != nil { | ||
| return | ||
| } | ||
| z := bytes.SplitN(buf[:n], []byte(" "), 3) | ||
| name := getProcName(z[1]) | ||
| p.p = &Process{p.pid, name} | ||
| stat.Close() |
There was a problem hiding this comment.
What happens, do you think, if stat.Read() fails? You would end up with an open
file descriptor.
cakturk
reviewed
Jan 17, 2020
| if err != nil { | ||
| return nil, err | ||
| } | ||
| tabs, err := parseSocktab(f, fn) | ||
| f.Close() | ||
| if err != nil { |
There was a problem hiding this comment.
Sorry, but, you're missing the point that you should only close file descriptors that
opened successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gracefully close open descriptors