-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Handle more dry-run cases #18286
base: main
Are you sure you want to change the base?
Conversation
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/20/24)1 reviewer was added to this PR based on Keith Williams's automation. |
196b740
to
eaaedec
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
eaaedec
to
1845e72
Compare
ab4549d
to
5853a7d
Compare
E2E results are ready! |
5853a7d
to
92d94b3
Compare
@@ -338,14 +338,15 @@ export async function handleConfirmation(args: { | |||
const isFirstBooking = index === 0; | |||
|
|||
if (!eventTypeMetadata?.disableStandardEmails?.all?.attendee) { | |||
await scheduleMandatoryReminder( | |||
evtOfBooking, | |||
await scheduleMandatoryReminder({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved all args to single object as I needed to add a new one
d698f56
to
b0de8f3
Compare
b0de8f3
to
14c3265
Compare
fa4fa8b
to
3740401
Compare
|
||
{/* <div className="border-subtle text-default mt-8 grid grid-cols-3 border-t pt-8 text-left"> | ||
<div className="font-medium">{t("what")}</div> | ||
<div className="col-span-2 mb-6">{sampleBookingInfo.title}</div> | ||
|
||
<div className="font-medium">{t("when")}</div> | ||
<div className="col-span-2 mb-6">{new Date(sampleBookingInfo.startTime).toLocaleString()}</div> | ||
|
||
<div className="font-medium">{t("who")}</div> | ||
<div className="col-span-2 mb-6"> | ||
<div className="mb-3"> | ||
<div> | ||
<span className="mr-2">{sampleBookingInfo.user.name}</span> | ||
<Badge variant="blue">{t("Host")}</Badge> | ||
</div> | ||
<p className="text-default">{sampleBookingInfo.user.email}</p> | ||
</div> | ||
<div> | ||
<p>{sampleBookingInfo.attendees[0].name}</p> | ||
<p>{sampleBookingInfo.attendees[0].email}</p> | ||
</div> | ||
</div> | ||
|
||
<div className="font-medium">{t("where")}</div> | ||
<div className="col-span-2 mb-6">{sampleBookingInfo.location}</div> | ||
</div> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets actually show the test data as a result. i like it
{/* <div className="border-subtle text-default mt-8 grid grid-cols-3 border-t pt-8 text-left"> | |
<div className="font-medium">{t("what")}</div> | |
<div className="col-span-2 mb-6">{sampleBookingInfo.title}</div> | |
<div className="font-medium">{t("when")}</div> | |
<div className="col-span-2 mb-6">{new Date(sampleBookingInfo.startTime).toLocaleString()}</div> | |
<div className="font-medium">{t("who")}</div> | |
<div className="col-span-2 mb-6"> | |
<div className="mb-3"> | |
<div> | |
<span className="mr-2">{sampleBookingInfo.user.name}</span> | |
<Badge variant="blue">{t("Host")}</Badge> | |
</div> | |
<p className="text-default">{sampleBookingInfo.user.email}</p> | |
</div> | |
<div> | |
<p>{sampleBookingInfo.attendees[0].name}</p> | |
<p>{sampleBookingInfo.attendees[0].email}</p> | |
</div> | |
</div> | |
<div className="font-medium">{t("where")}</div> | |
<div className="col-span-2 mb-6">{sampleBookingInfo.location}</div> | |
</div> */} | |
<div className="border-subtle text-default mt-8 grid grid-cols-3 border-t pt-8 text-left"> | |
<div className="font-medium">{t("what")}</div> | |
<div className="col-span-2 mb-6">{sampleBookingInfo.title}</div> | |
<div className="font-medium">{t("when")}</div> | |
<div className="col-span-2 mb-6">{new Date(sampleBookingInfo.startTime).toLocaleString()}</div> | |
<div className="font-medium">{t("who")}</div> | |
<div className="col-span-2 mb-6"> | |
<div className="mb-3"> | |
<div> | |
<span className="mr-2">{sampleBookingInfo.user.name}</span> | |
<Badge variant="blue">{t("Host")}</Badge> | |
</div> | |
<p className="text-default">{sampleBookingInfo.user.email}</p> | |
</div> | |
<div> | |
<p>{sampleBookingInfo.attendees[0].name}</p> | |
<p>{sampleBookingInfo.attendees[0].email}</p> | |
</div> | |
</div> | |
<div className="font-medium">{t("where")}</div> | |
<div className="col-span-2 mb-6">{sampleBookingInfo.location}</div> | |
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would actually need the actual dryRun results here, not static
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, thats planned for a followup as it has other dry run fixes as well.
What does this PR do?
Adds Dry Run success page that we can fill with more details later - Loom
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Try doing the booking