Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle more dry-run cases #18286

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Dec 20, 2024

What does this PR do?

  • Workflow
  • Seated Events
  • Webhooks

Adds Dry Run success page that we can fill with more details later - Loom
image

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • Not Needed - I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Try doing the booking

@graphite-app graphite-app bot requested a review from a team December 20, 2024 04:42
Copy link
Contributor

github-actions bot commented Dec 20, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Handle more dry-run cases". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking workflows area: workflows, automations labels Dec 20, 2024
@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Dec 20, 2024
Copy link

graphite-app bot commented Dec 20, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@hariombalhara hariombalhara changed the title Handle more dry-run cases fix: Handle more dry-run cases Dec 20, 2024
@hariombalhara hariombalhara force-pushed the more-handling-for-dry-run branch from 196b740 to eaaedec Compare December 20, 2024 04:53
Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 9:32am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 9:32am

Copy link
Contributor

github-actions bot commented Dec 20, 2024

E2E results are ready!

@@ -338,14 +338,15 @@ export async function handleConfirmation(args: {
const isFirstBooking = index === 0;

if (!eventTypeMetadata?.disableStandardEmails?.all?.attendee) {
await scheduleMandatoryReminder(
evtOfBooking,
await scheduleMandatoryReminder({
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved all args to single object as I needed to add a new one

@hariombalhara hariombalhara force-pushed the more-handling-for-dry-run branch 4 times, most recently from d698f56 to b0de8f3 Compare December 20, 2024 07:38
Comment on lines +47 to +72

{/* <div className="border-subtle text-default mt-8 grid grid-cols-3 border-t pt-8 text-left">
<div className="font-medium">{t("what")}</div>
<div className="col-span-2 mb-6">{sampleBookingInfo.title}</div>

<div className="font-medium">{t("when")}</div>
<div className="col-span-2 mb-6">{new Date(sampleBookingInfo.startTime).toLocaleString()}</div>

<div className="font-medium">{t("who")}</div>
<div className="col-span-2 mb-6">
<div className="mb-3">
<div>
<span className="mr-2">{sampleBookingInfo.user.name}</span>
<Badge variant="blue">{t("Host")}</Badge>
</div>
<p className="text-default">{sampleBookingInfo.user.email}</p>
</div>
<div>
<p>{sampleBookingInfo.attendees[0].name}</p>
<p>{sampleBookingInfo.attendees[0].email}</p>
</div>
</div>

<div className="font-medium">{t("where")}</div>
<div className="col-span-2 mb-6">{sampleBookingInfo.location}</div>
</div> */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets actually show the test data as a result. i like it

Suggested change
{/* <div className="border-subtle text-default mt-8 grid grid-cols-3 border-t pt-8 text-left">
<div className="font-medium">{t("what")}</div>
<div className="col-span-2 mb-6">{sampleBookingInfo.title}</div>
<div className="font-medium">{t("when")}</div>
<div className="col-span-2 mb-6">{new Date(sampleBookingInfo.startTime).toLocaleString()}</div>
<div className="font-medium">{t("who")}</div>
<div className="col-span-2 mb-6">
<div className="mb-3">
<div>
<span className="mr-2">{sampleBookingInfo.user.name}</span>
<Badge variant="blue">{t("Host")}</Badge>
</div>
<p className="text-default">{sampleBookingInfo.user.email}</p>
</div>
<div>
<p>{sampleBookingInfo.attendees[0].name}</p>
<p>{sampleBookingInfo.attendees[0].email}</p>
</div>
</div>
<div className="font-medium">{t("where")}</div>
<div className="col-span-2 mb-6">{sampleBookingInfo.location}</div>
</div> */}
<div className="border-subtle text-default mt-8 grid grid-cols-3 border-t pt-8 text-left">
<div className="font-medium">{t("what")}</div>
<div className="col-span-2 mb-6">{sampleBookingInfo.title}</div>
<div className="font-medium">{t("when")}</div>
<div className="col-span-2 mb-6">{new Date(sampleBookingInfo.startTime).toLocaleString()}</div>
<div className="font-medium">{t("who")}</div>
<div className="col-span-2 mb-6">
<div className="mb-3">
<div>
<span className="mr-2">{sampleBookingInfo.user.name}</span>
<Badge variant="blue">{t("Host")}</Badge>
</div>
<p className="text-default">{sampleBookingInfo.user.email}</p>
</div>
<div>
<p>{sampleBookingInfo.attendees[0].name}</p>
<p>{sampleBookingInfo.attendees[0].email}</p>
</div>
</div>
<div className="font-medium">{t("where")}</div>
<div className="col-span-2 mb-6">{sampleBookingInfo.location}</div>
</div>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would actually need the actual dryRun results here, not static

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thats planned for a followup as it has other dry run fixes as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e workflows area: workflows, automations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants