Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add name and email url params when rescheduling past bookings #18318

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kart1ka
Copy link
Contributor

@kart1ka kart1ka commented Dec 21, 2024

What does this PR do?

url.params.when.rescheduling.past.bookings.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link

vercel bot commented Dec 21, 2024

@kart1ka is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 21, 2024
@graphite-app graphite-app bot requested a review from a team December 21, 2024 19:17
@github-actions github-actions bot added bookings area: bookings, availability, timezones, double booking High priority Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Dec 21, 2024
@dosubot dosubot bot added the ✨ feature New feature or request label Dec 21, 2024
@dosubot dosubot bot added this to the v4.9 milestone Dec 21, 2024
Copy link

graphite-app bot commented Dec 21, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/21/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/21/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/23/24)

1 label was added to this PR based on Keith Williams's automation.

@retrogtx
Copy link
Contributor

adding responses: true, will help in getting rid of the type error in getServerSideProps.ts
I was trying to solve the same issue, hope this helps 🫡

image

@kart1ka
Copy link
Contributor Author

kart1ka commented Dec 22, 2024

adding responses: true, will help in getting rid of the type error in getServerSideProps.ts I was trying to solve the same issue, hope this helps 🫡

image

I am not getting any type error.

@retrogtx
Copy link
Contributor

retrogtx commented Dec 22, 2024

adding responses: true, will help in getting rid of the type error in getServerSideProps.ts I was trying to solve the same issue, hope this helps 🫡
image

I am not getting any type error.

nothing while using .reponses() ?
edit: you now added the response type as true in your last commit, which is why.
image

@Praashh
Copy link
Contributor

Praashh commented Dec 23, 2024

@kart1ka is correct 👌 , I am also not getting any type error and FYI: we also have a ci pipeline for type check as well
Screenshot 2024-12-23 at 10 21 44 AM
Screenshot 2024-12-23 at 10 21 58 AM

@retrogtx This is probably in your local machine, @retrogtx can you check again.

@retrogtx
Copy link
Contributor

responses: true

I get it but this is with responses: true, right?
Look at the order of commits, my comment was right after the first commit when it wasn't the case :D

Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking community Created by Linear-GitHub Sync ✨ feature New feature or request High priority Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-4944] URL params when rescheduling past bookings
3 participants