fix: Description not rendered as html in select event types screen when installing an app #18354
Conversation
…en installing an app
|
@asadath1395 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
event-types
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/23/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (12/23/24)1 label was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
It’s working fine for me. On which app is it not rendering HTML? @asadath1395
| @@ -4,6 +4,7 @@ import React from "react"; | |||
| import { useFieldArray, useFormContext } from "react-hook-form"; | |||
|
|
|||
| import { useLocale } from "@calcom/lib/hooks/useLocale"; | |||
| import { markdownToSafeHTML } from "@calcom/lib/markdownToSafeHTML"; | |||
There was a problem hiding this comment.
Don't we need to use markdownToSafeHTMLClient here? Could you please verify? Apart from this, it's okay
There was a problem hiding this comment.
It seems to throw error for me because of server-side rendering issue with DOMPurify. ref: vercel/next.js#46893. Maybe @SomayChauhan can help here since he implemented that function
Can you share screenshot? I was trying with google meet but the issue should appear in many apps. It is not an issue with any apps but soon after installing the app we ask users to select event types to which we want to install the app. |
|
you can see here @asadath1395, am also trying for gmeet. |
You didn't add any description to the event. This is mentioned in steps to reproduce Create an event with a description having links, bold or italic components |
|
@asadath1395 can you see |
What does this PR do?
Description not rendered properly in select event types screen if it has html elements when installing an app
Issue:
After solution:
Note: Right now there is a trimming happening which is similar behaviour we have in
/event-typesscreenMandatory Tasks (DO NOT REMOVE)
How should this be tested?