Fixed : Front page image smooth animation : #27 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is the PR appropiate, do i have to make some more changes |
Amark19
reviewed
Jun 19, 2024
can u check suggested changes ? |
|
is it Good, i have removed all the unwanted changes in the files |
|
hi, just a humble remainder |
Amark19
reviewed
Jun 23, 2024
|
|
||
|
|
||
| class BaseTranslatorTestCase(TestCase): | ||
| def setUp(self): | ||
| self.dummy_request = {"text": "My name is Amar"} | ||
| self.dummy_request = { | ||
| 'text': 'My name is Amar' |
There was a problem hiding this comment.
remove formatting change from this file too
| @@ -24,18 +24,35 @@ | |||
|
|
|||
| } | |||
|
|
|||
| .imge { | |||
There was a problem hiding this comment.
I think its the right time to change class name from imge to something readable as there are only 5 usages within same file.
Lets change it .
|
@abhinab-choudhury can u check now ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
video.mp4
Made Change in CSS for the Animation.