Custom thumb's component with additional props #655
+113
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request closes #154
It implements additional possibilities of customizing the Slider's thumb component.
Including:
currentValue
so that the main, custom component can know it's current position.currentValue
to know whether it is pass or before the thumb ("filled" or "empty").What is still to be done before merging:
Although it can be done in separate issue, as the docs would already use some attention to improve readability, especially considering extended options of customization.
We currently render a lot each go, so it would be good to take a closer look
The example implemented for new addition behaves incorrectly on iOS (the left section of custom thumb changes the position each step. It blinks for a moment before correctly render).
Below is the short demo with the implemented example:
(iOS to the left, Android on the right)
154-custom-component.mp4