Fix of big Regexp issue #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
excludeProperties fix Correct unittest, expects skipping of `behavior`
|
the time difference is factor 10, so 300ms vs 3000ms |
|
@timaschew, yes, 10 sec vs 1 sec in my case (building |
timaschew
added a commit
to componentjs/builder2.js
that referenced
this pull request
Oct 5, 2014
import callumlocke/css-url-rewriter#7 utils.js
|
+1. We've been bit by this (via grunt-cdnify). |
joakim
added a commit
to joakim/css-url-rewriter
that referenced
this pull request
Oct 14, 2014
joakim
added a commit
to joakim/css-url-rewriter
that referenced
this pull request
Oct 14, 2014
Fix bug not matching URLs on the same line as the opening bracket ({).
Manually merged with PR callumlocke#7.
stevenyxu
added a commit
to tatcha/grunt-cdnify
that referenced
this pull request
Nov 7, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
cssPropertyMatcherdid desperately wrong job. It matched too much, too slow.Test this css for example https://raw.githubusercontent.com/twbs/bootstrap/v3.2.0/dist/css/bootstrap.css
Because of this excludeProperties didn't work in some cases. And unitests was fixed up to this issue.
I've fixed regexp and related thing.