test(sql): Test fix for incorrect running instances count in process … #4752
+71
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
psavidis
force-pushed
the
SUPPORT-24279
branch
from
2151b08 to
df28120
Compare
Reviewer HintsAdded a test which verifies the correctness of statistics for the issue reproduction case
|
psavidis
added
ci:webapp-integration
psavidis
added
ci:default-build
psavidis
reviewed
Dec 19, 2024
| @@ -101,7 +101,6 @@ | |||
| ( | |||
| select | |||
| I.PROC_DEF_ID_ | |||
| , I.INCIDENT_TYPE_ | |||
There was a problem hiding this comment.
Context: Incident type is removed from the query's select, group by
psavidis
reviewed
Dec 19, 2024
| @@ -392,4 +393,73 @@ public void shouldSortResult() { | |||
| verifyOrderedResult("incidents", "asc", Arrays.asList("p2", "B", "p1", "A")); | |||
| verifyOrderedResult("incidents", "desc", Arrays.asList("A", "p1", "B", "p2")); | |||
| } | |||
|
|
|||
| @Test | |||
| public void shouldReturnCorrectStatistics() { | |||
There was a problem hiding this comment.
Context: Test that covers the correct statistics calculation for process instances with incidents (different types)
venetrius
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: The query
selectPDStatisticscalculates the total processInstances wrong.Used-by:
ProcessDefinitionRestService#getStatisticsCountWhy: The group by
incidentTypepart of the query should not be used for counting the total process instances.Tests: The commit adds a test which expects the correct statistics returned when process instances related to incidents with different types are used.
Related-to: https://jira.camunda.com/browse/SUPPORT-24279
#4756