-
Notifications
You must be signed in to change notification settings - Fork 133
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Demo: Add possibility to see the debug element in the demo page
The `createDebugElement` method allows to generate an RxPlayer-made debug element. It is used most often as a stats-for-nerds-like kind of things to quickly inspect, debug and report issues by displaying some interesting playback stats without having to dive into debug logs to obtain them. We didn't yet add a possibility to show them in the demo, so this commit quickly does that. It does it in the laziest way possible, by just adding a "Display debug element" checkbox in the chart area of the demo, which will display debug information on top of the media element when enabled and playing content. It may have more its place in the controls (which is what e.g. YouTube or Twitch choose to do in their production page for their debug divs, and Canal+' main products most often set it in a contextual menu), I don't even know if it does or not, but I was too lazy to do this just for our demo page. Putting it in chart was much simpler because no controls with checkbox exist yet, whereas charts only have checkboxes. So I just chose the easiest way!
- Loading branch information
1 parent
3d58a52
commit 0b52f81
Showing
4 changed files
with
82 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters