[WIP] Release v4.0.0 #1050
Closed
[WIP] Release v4.0.0 #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
added
work-in-progress
peaBerberian
force-pushed
the
next-v4
branch
3 times, most recently
from
9605f9a to
589355d
Compare
Closed
87 tasks
peaBerberian
force-pushed
the
next-v4
branch
from
3cfee44 to
502002a
Compare
peaBerberian
force-pushed
the
next-v4
branch
2 times, most recently
from
5cda0e5 to
8d86f65
Compare
peaBerberian
force-pushed
the
next
branch
2 times, most recently
from
b313d32 to
d5c0748
Compare
peaBerberian
force-pushed
the
next-v4
branch
5 times, most recently
from
7291c24 to
f2035ff
Compare
peaBerberian
force-pushed
the
next
branch
3 times, most recently
from
b67e176 to
f45bcce
Compare
peaBerberian
force-pushed
the
next
branch
3 times, most recently
from
3668ba7 to
b0968f0
Compare
`DASH_WASM`, `DEBUG_ELEMENT` become non-experimental features and `parseBifThumbnails` a non-experimental tool
- Seek exactly to the current position if setAudio/Video track if relativeResumingPosition was set intentionnaly to 0. - Add types.
types: export type IcompatibleKeySystem to the public API
using global import, ex: `__ENVIRONMENT__` in the `demo/full` folder didn't work because there is a `demo/full/tsconfig` file that has more priority than `src/tsconfig` in the `demo/full` folder. The fix was to add the global import file in the `demo/full/tsconfig`
Building of the RxPlayer's WebAssembly file previously required:
1. that the Rust compiler toolchain is installed (most likely through
`rustup`) and that `cargo` is consequently available as a command
globally.
2. that the `wasm32-unknown-unknown` Rust compiler target is added
(this is generally just basically a `rustup target add
wasm32-unknown-unknown` call once rustup is installed).
3. that the `binaryen` tool is installed and that `wasm-opt` is
consequently available as a command globally.
It bothered me that we added Rust compiler toolchains requirements for
building what is a JavaScript project, even more now that we're
considering making it a requirement for the `npm run build` script.
To simplify, I try here to remove the need for the third step, which
might be the more complex to set up (`binaryen` seems to be available
through `brew` for MacOS and it is in the `extra` repository for Arch,
but I would guess that many other linux distributions wouldn't have an
easy access to it, leading to installing and updating difficulties).
To remove it, I rely on a WebAssembly build of binaryen with a JS API on
the front, through the `binaryen` npm module.
It is quite voluminous (25MB in my `node_modules` directory, making it
second after TypeScript) yet it save the need to separately have to
install and maintain a separate binary.
I then added the `script/wasm-optimize.mjs` script to interface with
that npm module and called it through the `npm run build:wasm:release`
script, which should completely replace the need for binaryen.
fix(demo): fix ts error in global declaration
Remove the necessity of installing binaryen separately
Previous RxPlayer's `mute` and `unMute` method actually set the volume
to `0` instead of changing the `muted` HTMLMediaElement property.
I here propose that we update their behavior to mutate the `muted`
property instead as:
1. It would seem more natural to an application I would guess
2. It might integrate better with browsers built-in making use of the
`HTMLMediaElement` properties directly (things like
Picture-in-Picture and so on).
I also consequently updated that the `volumeChange` event to notify
about both properties, and noticed it wasn't even documented in the API
documentation.
if user has set relativeResumingPosition, the seek should be on exact position provided, but if the value was defaulted by the API, let the possibility to change slightly this value to make sure the browser will correctly reload the video.
…mitVideoWidth demo: change removed property limitVideoWidth to videoResolutionLimit
feat: change position on audio track change
…content was directfile
Set more standard mute/unMute behaviors
fix(demo): directFiles content was not working in the demo
|
As the v4.0.0-rc.1 is pretty stable, keeping this branch as a safety mechanism is no longer needed, we can close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STATUS: Already merged in the v4.0.0-rc.1