RepresentationStream: Also check segments after a Manifest update #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mechanism to check if new segments are available are done on several events but was not done on a Manifest update. Even if for complex reasons, there is small advantages to not check for new segments directly after a Manifest update, it also seems in most cases more logical and efficient. I decided to add it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mechanism to check for new segment to request is done on several events but was not done on a Manifest update.
Even if for complex reasons, there are small advantages to not check for new segments directly after a Manifest update, it also seems in most cases more logical and efficient.
I decided to add it.