Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] scte214 - use supplemental codec instead of base codec if it's supported #1307
[Proposal] scte214 - use supplemental codec instead of base codec if it's supported #1307
Changes from 2 commits
7d1ecef
85b5941
09e1d03
6c67e53
e7d22a6
c5cb8c7
c57acb9
d14148b
2d56d1a
3d7d1da
49d1a7d
385b533
7bdef9d
9010407
a02d3df
0a694d7
be795bc
b16c914
435033d
99d3a3f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you use a !==, in order to verify also the type or the existing isNullOrUndefined method in the utils?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used to check if the value is either
null
orundefined
,@peaBerberian is there any recommandations about using
!=
or the function!isNullOrUndefined
?Both syntax exists in the project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we now try to avoid relying on double equals in the RxPlayer as:
Here the intent is to have to check explicitely for what can happen. In some situations where only
null
xorundefined
are possible at first, we may create a bug in future code if ever the other value become possible.There are some areas of the code still relying on the
== null
trick, but that's old logic we ultimately want to replace them by more explicit code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, should I change all the
!=
to!isNullOrUndefined
in theparse_representation.ts
file, or should I do another MR for this change ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you want, both are good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here isn't it only
undefined
though? I'm unsureThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think too it's only
undefined
but as a precaution I didn't want to change the behavior of the API.