Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WASM parser): parse correctly <Label> to a tag and not an attribute #1543

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

Florent-Bouisset
Copy link
Collaborator

backport fix #1541 into v3

parsersStack.pushParsers(
nodeId,
noop, // Label as treated like an attribute
generateLabelElementParser(adaptationSetChildren, linearMemory),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

OK.... I'll do the prettier PR next

@peaBerberian peaBerberian added this to the 3.33.4 milestone Sep 13, 2024
@peaBerberian peaBerberian added bug This is an RxPlayer issue (unexpected result when comparing to the API) DASH Relative to the DASH streaming protocol WASM Relative to our WebAssembly code labels Sep 13, 2024
@peaBerberian peaBerberian merged commit 9be06de into legacy-v3 Sep 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is an RxPlayer issue (unexpected result when comparing to the API) DASH Relative to the DASH streaming protocol WASM Relative to our WebAssembly code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants