Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SourceBuffer.prototype.remove error handling #1560

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

peaBerberian
Copy link
Collaborator

I noticed an issue when handling errors from the MSE SourceBuffer.prototype.remove API, where our MSE abstraction was emptying all pending operations (appendBuffer calls and remove calls after that one) yet wasn't also rejecting those other operations' Promise, meaning that the RxPlayer logic wouldn't be notified that those operations were canceled.

This may lead to some rare infinite rebuffering.

I noticed an issue when handling errors from the MSE
`SourceBuffer.prototype.remove` API, where our MSE abstraction was
emptying all pending operations (`appendBuffer` calls and `remove`
calls after that one) yet wasn't also rejecting those other
operations' Promise, meaning that the RxPlayer logic wouldn't be
notified that those operations were canceled.

This may lead to some rare infinite rebuffering.
@peaBerberian peaBerberian added the Priority: 0 (Very high) This issue or PR has a very high priority. Efforts should be concentrated on it first. label Oct 1, 2024
@peaBerberian peaBerberian added this to the 4.2.0 milestone Oct 1, 2024
@peaBerberian peaBerberian added the bug This is an RxPlayer issue (unexpected result when comparing to the API) label Oct 1, 2024
@peaBerberian peaBerberian merged commit 4a940b0 into dev Oct 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is an RxPlayer issue (unexpected result when comparing to the API) Priority: 0 (Very high) This issue or PR has a very high priority. Efforts should be concentrated on it first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants