MULTI_THREAD: Fix onmessageerror being undefined #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently defined a `onmessageerror` global callback on the WebWorker-side of the `MULTI_THREAD` feature, thinking that it was defined, like the `onmessage` callback, as long as WebWorker were accessible. Turns out that was not the case at all, and the multithreading mode was breaking on older device. Oops, sorry about that. As it is not required, we can just access it through our `globalScope` shortcut to the global object. This way, it will just define a callback which will never be called if it does not exist.
peaBerberian
added
bug
Florent-Bouisset
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently defined a
onmessageerrorglobal callback on the WebWorker-side of theMULTI_THREADfeature, thinking that it was defined, like theonmessagecallback, as long as WebWorker were accessible.Turns out that was not the case at all, and the multithreading mode was breaking on older device. Oops, sorry about that.
As it is not required, we can just access it through our
globalScopeshortcut to the global object. This way, it will just define a callback which will never be called if it does not exist.