-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding saml2 support #62
Conversation
@UtkarshBhatthere hey, this is blocked by #63 ? and it is also blocked by the other issues? |
I had raised 63 to check if pinning to an LTS LXD release fixes the build failures. It is not necessarily blocking (unless it fixes the build job). I have triggered reruns for jobs on this PR and on #63. |
1ec437f
to
ad3ffc4
Compare
I see thanks. rook script https://github.com/rook/rook/blob/release-1.12/tests/scripts/github-action-helper.sh#L23 Thanks a lot. |
b3543d1
to
79494ac
Compare
not sure why rook script is not working(empty value) but if I copy them to this code, it works. (still has more issues after the test) |
Fixing below error by adding proper pkg $ ceph dashboard sso show saml2 Error EPERM: Required library not found: `python3-saml` Closes canonical#57 Signed-off-by: Seyeong Kim <[email protected]>
7c373b0
to
29e91d9
Compare
To unblock GH CI for building ceph rocks Signed-off-by: Utkarsh Bhatt <[email protected]>
29e91d9
to
2565c85
Compare
@xtrusia I am pretty sure that the env disk layout changed and the bash script simply couldn't fetch required disk anymore. Good news is that I have removed the rockcraft-pack-action dependency and switched to rockcraft snap directly. We are able to build the rock,. |
Fixing below error by adding proper pkg
$ ceph dashboard sso show saml2
Error EPERM: Required library not found:
python3-saml
Closes #57
previous PR
#58