Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding saml2 support #62

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

xtrusia
Copy link
Contributor

@xtrusia xtrusia commented Aug 8, 2024

Fixing below error by adding proper pkg

$ ceph dashboard sso show saml2
Error EPERM: Required library not found: python3-saml

Closes #57

previous PR
#58

@xtrusia
Copy link
Contributor Author

xtrusia commented Aug 20, 2024

@UtkarshBhatthere hey, this is blocked by #63 ? and it is also blocked by the other issues?
Thanks a lot for your working.

@UtkarshBhatthere
Copy link
Contributor

I had raised 63 to check if pinning to an LTS LXD release fixes the build failures. It is not necessarily blocking (unless it fixes the build job). I have triggered reruns for jobs on this PR and on #63.

@xtrusia xtrusia force-pushed the adding-saml2 branch 3 times, most recently from 1ec437f to ad3ffc4 Compare August 21, 2024 02:38
@xtrusia
Copy link
Contributor Author

xtrusia commented Aug 21, 2024

I see thanks. rook script https://github.com/rook/rook/blob/release-1.12/tests/scripts/github-action-helper.sh#L23
returns nothing
and try to wipefs with just '1'
I'm analyzing this why it is happening. if you have any advice, please let me know.

Thanks a lot.

@xtrusia xtrusia force-pushed the adding-saml2 branch 7 times, most recently from b3543d1 to 79494ac Compare August 21, 2024 05:17
@xtrusia
Copy link
Contributor Author

xtrusia commented Aug 21, 2024

not sure why rook script is not working(empty value) but if I copy them to this code, it works. (still has more issues after the test)

Fixing below error by adding proper pkg

$ ceph dashboard sso show saml2
Error EPERM: Required library not found: `python3-saml`

Closes canonical#57

Signed-off-by: Seyeong Kim <[email protected]>
@UtkarshBhatthere UtkarshBhatthere force-pushed the adding-saml2 branch 3 times, most recently from 7c373b0 to 29e91d9 Compare September 2, 2024 12:12
To unblock GH CI for building ceph rocks

Signed-off-by: Utkarsh Bhatt <[email protected]>
@UtkarshBhatthere
Copy link
Contributor

UtkarshBhatthere commented Sep 2, 2024

@xtrusia I am pretty sure that the env disk layout changed and the bash script simply couldn't fetch required disk anymore. Good news is that I have removed the rockcraft-pack-action dependency and switched to rockcraft snap directly. We are able to build the rock,.

@UtkarshBhatthere UtkarshBhatthere merged commit 879be92 into canonical:main Sep 2, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error EPERM: Required library not found: python3-saml
2 participants