Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uninstall custom signal handlers before shutdown #5913

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Dec 5, 2024

Proposed Commit Message

fix: uninstall custom signal handlers before shutdown

Fixes GH-5849
Fixes LP: 2089185

Additional Context

This might address the following bug reports:

https://bugs.launchpad.net/maas/+bug/2089185
#5849

Test Steps

I haven't been able to reproduce either bug, so testing is needed.

Here is are debs for testing (funny name because Github is unaware of the existence of debian files):

noble: cloud-init_24.3.1-1174-gf7bbd23d-1~bddeb_all.tar.gz
jammy: cloud-init_24.3.1-1016-ge3d0bcd4-1~bddeb_all.tar.gz

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@TheRealFalcon
Copy link
Member

@holmanb , I'm assuming we're looking for some confirmation that this approach works before reviewing?

@r00ta
Copy link
Contributor

r00ta commented Dec 17, 2024

We tested this patch in MAAS but it does not work. As per chat we decided to release a fix in MAAS directly.

So, if this patch was supposed to be used only for MAAS we can close it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants