Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Trigger actions on PR merges and release branches #46

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix: Trigger actions on PR merges and release branches #46

merged 1 commit into from
Dec 12, 2024

Conversation

ghislainbourgeois
Copy link
Contributor

Description

The previous PR (#45) removing the trigger on push had the unintended effect of disabling CI when merging a PR. This PR re-enables the push event, but limits it only to the main and release branches.

Similarly, it also triggers for PRs targeting release branches.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ghislainbourgeois ghislainbourgeois requested a review from a team as a code owner December 12, 2024 00:14
@ghislainbourgeois ghislainbourgeois merged commit 3bc423b into main Dec 12, 2024
6 checks passed
@ghislainbourgeois ghislainbourgeois deleted the fix-enable-push-on-main branch December 12, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriciareinoso patriciareinoso patriciareinoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghislainbourgeois @patriciareinoso