fix: Fix preview card button being squashed #4945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
chillkang
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
steverydz
added a commit
that referenced
this pull request
Jan 6, 2025
fix: Ignore metrics TS errors for now (#4933) fix: Fix checkbox values resetting in publisher settings form (#4937) fix: Fix primary website field clearing on revert (#4938) fix: Make sure Edit button on preview page closes current tab (#4939) fix: Fix deleting icon or banner not activating save button (#4940) fix: render selected language in HTML and markdown snippets (#4942) fix: remove extra whitespace in embeddable card (#4943) fix: Fix missing contact links in preview (#4944) fix: Fix preview card button being squashed (#4945) fix: Fix display of releases table (#4946) fix: Add loading state to single build page (#4947) fix: ensure markdown is rendered correctly (#4948) fix: build page showing stale data while fetching logs (#4949) fix: Fix missing banner in listing publisher page (#4950) fix: Fix form not resetting when making changes to images (#4952)
steverydz
added a commit
that referenced
this pull request
Jan 6, 2025
* feat: Move publicise into publisher app (#4844) * feat: Move settings into publisher app (#4847) * Wd 14634 metrics page (#4851) * feat: migrate metrics page to react * Wd 15262 improve performance of metric page (#4863) * feat: added downsampling and pagination * chore: Move listing page into publisher app (#4865) * feat: add breadcrumb nav to the metrics page (#4871) * feat: Create endpoints to get repo data and builds data (#4873) * feat: update badge sources (#4892) * feat: Add builds section to publisher pages (#4890) Simplify step 1 Simplify step 2 Simplify step 3 Simplify step 4 Simplify step 5 * feat: Move releases section into the publisher app (#4902) * fix: Fix publicise disabled notification (#4911) * fix: Fix issue with saving settings when navigating from listing (#4913) * fix: Fix publicise view for private snaps (#4914) * Rebase * fix: Fix issues with tour styles (#4916) * fix: Fix code linting errors in publisher app (#4921) * fix: Fix a11y errors in builds section (#4922) * fix: Fix publisher a11y errors in the publicise cards section (#4923) * fix: Fix publisher a11y errors in publicise badges section (#4924) * fix: Fix publisher a11y errors in publicise buttons section (#4925) * fix: Fix publisher a11y errors in settings section (#4926) * fix: Fix a11y errors in license search (#4928) * fix: Fix a11y errors in search autocomplete (#4929) * chore: Remove legacy publisher JS (#4930) fix: Ignore metrics TS errors for now (#4933) fix: Fix checkbox values resetting in publisher settings form (#4937) fix: Fix primary website field clearing on revert (#4938) fix: Make sure Edit button on preview page closes current tab (#4939) fix: Fix deleting icon or banner not activating save button (#4940) fix: render selected language in HTML and markdown snippets (#4942) fix: remove extra whitespace in embeddable card (#4943) fix: Fix missing contact links in preview (#4944) fix: Fix preview card button being squashed (#4945) fix: Fix display of releases table (#4946) fix: Add loading state to single build page (#4947) fix: ensure markdown is rendered correctly (#4948) fix: build page showing stale data while fetching logs (#4949) fix: Fix missing banner in listing publisher page (#4950) fix: Fix form not resetting when making changes to images (#4952) --------- Co-authored-by: ilayda-cp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Fixed issue where preview card button is squashed
How to QA
Testing
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-17679