Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i/p/requestrules,o/i/apparmorprompting: move request matching logic into requestrules #14635

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

i/p/requestrules,o/i/apparmorprompting: move request matching logic into requestrules #14635

wants to merge 1 commit into from

Conversation

olivercalder
Copy link
Member

@olivercalder olivercalder commented Oct 17, 2024 •
edited
Loading

This PR builds on #14865, only the final commit is relevant to this PR.

Move the logic which iterates through requested permissions into the requestrules package, instead of the o/i/apparmorprompting package.

This work is tracked internally by https://warthogs.atlassian.net/browse/SNAPDENG-31370

@github-actions github-actions bot added the Needs Documentation -auto- Label automatically added which indicates the change needs documentation label Oct 17, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.28%. Comparing base (24a0034) to head (8fadf37).
Report is 75 commits behind head on master.

Files with missing lines Patch % Lines
interfaces/prompting/requestrules/requestrules.go 90.47% 2 Missing ⚠️
overlord/ifacestate/apparmorprompting/prompting.go 84.61% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #14635      +/-   ##
==========================================
+ Coverage   78.20%   78.28%   +0.07%     
==========================================
  Files        1151     1155       +4     
  Lines      151396   152616    +1220     
==========================================
+ Hits       118402   119477    +1075     
- Misses      25662    25768     +106     
- Partials     7332     7371      +39
Flag Coverage Δ
unittests 78.28% <88.23%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olivercalder olivercalder force-pushed the prompting-move-request-matching-logic-down branch 2 times, most recently from c00fe34 to d9d8469 Compare November 14, 2024 20:54
@olivercalder olivercalder mentioned this pull request Nov 24, 2024
Open
@pedronis pedronis added the Needs Samuele review Needs a review from Samuele before it can land label Dec 2, 2024
@olivercalder olivercalder requested review from pedronis and removed request for pedronis December 2, 2024 21:20
@olivercalder olivercalder force-pushed the prompting-move-request-matching-logic-down branch 3 times, most recently from dd82a2c to 3bfc9f6 Compare December 9, 2024 18:49
@olivercalder olivercalder force-pushed the prompting-move-request-matching-logic-down branch from 3bfc9f6 to 93c202b Compare December 18, 2024 18:33
@github-actions github-actions bot removed the Needs Documentation -auto- Label automatically added which indicates the change needs documentation label Dec 18, 2024
@olivercalder olivercalder force-pushed the prompting-move-request-matching-logic-down branch 2 times, most recently from ca1bcdd to 7b63769 Compare December 18, 2024 19:22
bboozzoo
bboozzoo approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrewphelpsj
andrewphelpsj approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@andrewphelpsj andrewphelpsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pedronis
pedronis approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@olivercalder olivercalder force-pushed the prompting-move-request-matching-logic-down branch from 7b63769 to 8fadf37 Compare December 20, 2024 14:20
@olivercalder
Copy link
Member Author

Test failures:

  • openstack:centos-9-64 --- openstack allocation limit
  • openstack:debian-12-64 --- openstack allocation limit
  • openstack:debian-sid-64 --- openstack allocation limit
  • openstack:fedora-40-64 --- openstack allocation limit
  • openstack:fedora-41-64 --- openstack allocation limit
  • openstack:opensuse-15.6-64 --- openstack allocation limit
  • openstack:opensuse-tumbleweed-64 --- openstack allocation limit
  • google:ubuntu-16.04-64:tests/main/auto-refresh-backoff --- known, unrelated
  • google:ubuntu-16.04-64:tests/main/auto-refresh-gating --- known, unrelated
  • google:ubuntu-16.04-64:tests/main/auto-refresh-gating-from-snap --- known, unrelated
  • google:ubuntu-16.04-64:tests/main/auto-refresh:regular --- known, unrelated
  • google:ubuntu-16.04-64:tests/main/refresh-app-awareness-notify --- known, unrelated
  • google:ubuntu-24.04-64:tests/main/snap-seccomp-syscalls --- unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewphelpsj andrewphelpsj andrewphelpsj approved these changes

@pedronis pedronis pedronis approved these changes

@bboozzoo bboozzoo bboozzoo approved these changes

Assignees
No one assigned
Labels
Needs Samuele review Needs a review from Samuele before it can land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olivercalder @bboozzoo @pedronis @andrewphelpsj