o/snapstate, overlord, o/devicestate: support downloading components in snapstate.Download #14835
Conversation
andrewphelpsj
force-pushed
the
snapstate-download-components
branch
from
88f3b2d to
8b8a47e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14835 +/- ##
==========================================
+ Coverage 78.20% 78.27% +0.06%
==========================================
Files 1151 1153 +2
Lines 151396 152219 +823
==========================================
+ Hits 118402 119152 +750
- Misses 25662 25706 +44
- Partials 7332 7361 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
overlord/snapstate/snapmgr.go
Outdated
| @@ -245,6 +248,26 @@ func (compsu *ComponentSetup) Revision() snap.Revision { | |||
| return compsu.CompSideInfo.Revision | |||
| } | |||
|
|
|||
| func (compsu *ComponentSetup) MountFile(instanceName string) string { | |||
There was a problem hiding this comment.
this needs a doc comment, also it's slightly strange name for this given that it takes into account a variable BlobDir, this is the mount file only if DownloadBlobDir is unset
There was a problem hiding this comment.
This is symmetric with the MountFile method on SnapSetup. Maybe they both could be renamed? SourceFile? BlobPath?
overlord/snapstate/snapmgr.go
Outdated
| @@ -197,8 +197,10 @@ func (snapsup *SnapSetup) MountDir() string { | |||
| return snap.MountDir(snapsup.InstanceName(), snapsup.Revision()) | |||
| } | |||
|
|
|||
| // MountFile returns the path to the snap/squashfs file that is used to mount the snap. | |||
| func (snapsup *SnapSetup) MountFile() string { | |||
| // BlobPath returns the path to the snap/squashfs file that is backs the snap | |||
…in snapstate.Download
…gainst validation sets
…ponent}Setup.MountFile to BlobPath
andrewphelpsj
force-pushed
the
snapstate-download-components
branch
from
c206dcd to
6b29345
Compare
|
Only required failure is |
This will enable us to download arbitrary components for the purpose of creating a recovery system. Follow-up PR will move where we download the blobs to from the global blob dir, to somewhere under
/var/cache/snapd.