many: move secboot.EncryptionType under gadget/device

[ZeyadYasser]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (fde-manager-features@4d6452a). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
gadget/device/encrypt.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@                   Coverage Diff                   @@
##             fde-manager-features   #14855   +/-   ##
=======================================================
  Coverage                        ?   78.84%           
=======================================================
  Files                           ?     1093           
  Lines                           ?   148188           
  Branches                        ?        0           
=======================================================
  Hits                            ?   116837           
  Misses                          ?    24056           
  Partials                        ?     7295           

Flag	Coverage Δ
unittests	78.84% <93.75%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[miguelpires]

@ZeyadYasser the code changes LGTM, can you just give me a bit of context on why we need to do this?

[ZeyadYasser]

@ZeyadYasser the code changes LGTM, can you just give me a bit of context on why we need to do this?

This is a followup to #14845 (comment), to avoid importing secboot from the client (and therefore cmd/snap) package, it was previously defined as a string. This moving to gadget/device was done for a new field due to the same constraint, so cleanup for the existing EncryptionType field was suggested.

[miguelpires]

Thanks

[bboozzoo]

Thanks