interfaces/seccomp/template: allow epoll_pwait2 in the base template #14885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add epoll_pwait2 in the base template. The syscall has been available since 5.11 (early 2021). Signed-off-by: Maciej Borzecki <[email protected]>
zyga
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
LGTM based on https://man.archlinux.org/man/epoll_pwait2.2.en
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14885 +/- ##
==========================================
+ Coverage 78.20% 78.27% +0.06%
==========================================
Files 1151 1143 -8
Lines 151396 152192 +796
==========================================
+ Hits 118402 119122 +720
- Misses 25662 25720 +58
- Partials 7332 7350 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add epoll_pwait2 in the base template. The syscall has been available since 5.11 (early 2021).
Reported in the forum: https://forum.snapcraft.io/t/epoll-works-on-core20-but-fails-on-core22/44347
Some context: https://kernelnewbies.org/Linux_5.11#Add_epoll_pwait2.282.29_syscall_for_higher_resolution_waits
Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?