Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: change main rule so that changes in nested tests won't run main #14889

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maykathm
Copy link
Contributor

@maykathm maykathm commented Dec 20, 2024

This maps anything under tests/nested to nothing. With this change, in future PRs, if the PR's only change is a nested test, the non-nested systems will not run any tests.

Here's the change to the main.yaml rule file in action:

$ python3 tests/lib/external/snapd-testing-tools/utils/spread-filter -r tests/lib/spread/rules/main.yaml -p google::ubuntu-24.04-64 -c tests/nested/manual/some-test/task.yaml

$

@maykathm maykathm added the Simple 😃 A small PR which can be reviewed quickly label Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.28%. Comparing base (24a0034) to head (7602d96).
Report is 73 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14889      +/-   ##
==========================================
+ Coverage   78.20%   78.28%   +0.08%     
==========================================
  Files        1151     1156       +5     
  Lines      151396   152624    +1228     
==========================================
+ Hits       118402   119489    +1087     
- Misses      25662    25763     +101     
- Partials     7332     7372      +40     
Flag Coverage Δ
unittests 78.28% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@olivercalder olivercalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants