Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-factor Pebble Layer update using chisme #144

Closed
wants to merge 5 commits into from

Conversation

Thanhphan1147
Copy link

@Thanhphan1147 Thanhphan1147 commented Oct 2, 2023

I refactored the pebble layer update to use the helper function from charmed_kubeflow_chisme.pebble. I also update some dependencies missing for unit tests and update some of the libraries.

Note: tox -e unit was failling for me saying that cosl is a missing dependency

Closes #94

@Thanhphan1147 Thanhphan1147 marked this pull request as ready for review October 3, 2023 11:41
@Thanhphan1147 Thanhphan1147 requested a review from a team as a code owner October 3, 2023 11:41
@Thanhphan1147 Thanhphan1147 reopened this Oct 3, 2023
@Thanhphan1147
Copy link
Author

Since CI is disabled for forks I have attached the results of tests:

tox -e charm-integration
image

tox -e unit
image

tox -e lint
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-factor Pebble Layer update using chisme
1 participant