-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Add explanation about sponsorship #75
base: 2.0-preview
Are you sure you want to change the base?
Conversation
@rkratky the checks are showing spelling errors because of how some external pages are referenced. For example, in line 23:
Do you think I should change "SeekingSponsorship" to "Seeking Sponsorship"? |
change to british spelling; removed broken link
12d5219
to
ef84709
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice changes overall, thanks for submitting them :) I've left a few inline nits - I think you are quite right, and it would be better to split the link text to match a proper sentence structure than to add them to the spelling exception list. I've added suggestions for all those, to make it easier to batch apply them.
Co-authored-by: Sally <[email protected]> Update docs/explanation/sponsorship.rst Co-authored-by: Sally <[email protected]>
b63127a
to
e0aa56f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rkratky I think this is ready to go, except for the CI checks that aren't passing (but those are unrelated to the PR).
The "broken" links correspond to an outage that we had on the Ubuntu main site a couple of weeks ago, so I'm not worried about those.
The spelling errors being thrown are a mixture of genuine spelling errors (that should be fixed) and terms that need to be added to the exception list, but from what I can none of them are related to this PR. I'll leave it to you to decide if they ought to be fixed now or if we can merge as-is (for them to be fixed later).
This pull request solves issue 101 of the open-documentation-repository by adding an explanation docs about Sponsorship.
The pull request changes the file's name from sponsoring.rst to sponsorship.rst and also changes its title from Sponsoring to Sponsorship.