-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass along UTMs when doing a blog redirect #13381
Conversation
Demo starting at https://ubuntu-com-13381.demos.haus |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13381 +/- ##
=======================================
Coverage 74.41% 74.41%
=======================================
Files 107 107
Lines 2838 2838
Branches 946 946
=======================================
Hits 2112 2112
Misses 702 702
Partials 24 24 |
Somehow, this doesn't work in the demo, but it works locally... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm that it works locally for me as well. Not sure why it fails on the demo server though. Let's maybe wait for a second reviewer from sites, who might know which could be the reason.
webapp/views.py
Outdated
@@ -736,10 +736,17 @@ def dispatch_request(self, slug): | |||
if "article" not in context: | |||
return flask.abort(404) | |||
|
|||
# Redirect canonical annoucements | |||
# Capture the original query string | |||
original_query_string = flask.request.query_string.decode("utf-8") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this variable is used only inside the if
block below, can you declare it there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akbarkz done, good catch, thank you
Done
QA