-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add product cards #13772
base: main
Are you sure you want to change the base?
Add product cards #13772
Conversation
modified: templates/blog/product-cards.html new file: templates/blog/product-cards/_ai-solutions.html new file: templates/blog/product-cards/_ceph.html new file: templates/blog/product-cards/_charmed_mongodb.html new file: templates/blog/product-cards/_desktop_ubuntu-desktop-for-organisations.html new file: templates/blog/product-cards/_desktop_ubuntu-for-desktops.html new file: templates/blog/product-cards/_infrastructure_maximise-your-cloud-infrastructure.html new file: templates/blog/product-cards/_infrastructure_optimised-costs-across-any-cloud.html new file: templates/blog/product-cards/_kubernetes.html new file: templates/blog/product-cards/_lxd.html new file: templates/blog/product-cards/_microcloud.html new file: templates/blog/product-cards/_opensearch.html new file: templates/blog/product-cards/_openstack.html new file: templates/blog/product-cards/_server_scale-out-with-ubuntu-server.html new file: templates/blog/product-cards/_wsl_ubuntu-on-windows.html
julia-queen is not a collaborator of the repo |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13772 +/- ##
=======================================
Coverage 74.51% 74.51%
=======================================
Files 107 107
Lines 2857 2857
Branches 957 957
=======================================
Hits 2129 2129
Misses 704 704
Partials 24 24 |
@caldav will take the ownership of this PR if it's not merged before the end of the week. I allowed edits and access to secrets by maintainers |
Hey @julia-queen @caldav , could you please look into the demo, it's not working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the PR.
I have left a couple of comments regarding alt text, hr tags and em dash.
Please try to fix those for all the pages in the PR.
<img class="p-card__thumbnail" | ||
src="https://assets.ubuntu.com/v1/9e27d14a-Ubuntu%[email protected]" | ||
alt="ubuntu logo" /> | ||
<hr class="u-sv1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the latest vanilla version we either have p-rule
or p-rule--muted
class with <hr>
tags. Could you please amend this for all hr tags in the PR
<div class="p-card js-product-card u-hide"> | ||
<img class="p-card__thumbnail" | ||
src="https://assets.ubuntu.com/v1/9e27d14a-Ubuntu%[email protected]" | ||
alt="ubuntu logo" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not add "logo" word to mention it's logo. Just leaving out the name will be good enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer here for all alt="" related info
</h3> | ||
<img class="p-card__thumbnail" | ||
src="https://assets.ubuntu.com/v1/e549fdc0-Canonical-AI-ML-Illustrations-v5-03.png" | ||
alt="canonical ai ml illustration" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might not require an alt="" here. Please refer the doc I had pinned in one of comments.
<a href="https://www.canonical.com/solutions/infrastructure">Maximise your cloud infrastructure</a> | ||
</h3> | ||
<p> | ||
Canonical lets you take control of your cloud, cutting costs and easily mixing private and public cloud platforms – all with a 10-year security guarantee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a emdash
here
<a href="https://canonical.com/lxd">Fast, dense, and secure container and VM management at any scale</a> | ||
</h3> | ||
<p> | ||
LXD brings flexible resource limits, advanced snapshot and networking support, and better security – all making for easier, leaner and more robust containerised solutions and VMs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LXD brings flexible resource limits, advanced snapshot and networking support, and better security – all making for easier, leaner and more robust containerised solutions and VMs. | |
LXD brings flexible resource limits, advanced snapshot and networking support, and better security &mdash all making for easier, leaner and more robust containerised solutions and VMs. |
<a href="/openstack">Smart operations, optimal architecture, better pricing.</a> | ||
</h3> | ||
<p> | ||
OpenStack and Ubuntu bring automated deployment and management that help you optimise infrastructure costs – no matter your industry or use case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
&mdash here
Done
QA
Issue / Card
Fixes # https://warthogs.atlassian.net/browse/GROWENG-3389
Fixes # https://warthogs.atlassian.net/browse/GROWENG-3335
Fixes # https://warthogs.atlassian.net/browse/GROWENG-3334
Fixes # https://warthogs.atlassian.net/browse/GROWENG-3331
Fixes # https://warthogs.atlassian.net/browse/GROWENG-3330
Fixes # https://warthogs.atlassian.net/browse/GROWENG-3328
Fixes # https://warthogs.atlassian.net/browse/GROWENG-3074
Screenshots
[If relevant, please include a screenshot.]
Help
QA steps - Commit guidelines