add check for contractItemID validity to prevent 500 #14435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usamabinnadeem-10
requested review from
anthonydillon,
abhigyanghosh30 and
minkyngkm
Demo
Jenkins 
demos.haus
usamabinnadeem-10
requested review from
fasih-mehmood
and removed request for
anthonydillon
|
This is not relevant to the error btw |
|
@abhigyanghosh30 the error is related to the contractItemID being an empty string. Previously the id was being read from the form but now I am extracting that directly from the query and if it is not present we show an error and don't schedule the exam in that scenario. |
|
@abhigyanghosh30 can you reply to the last comment please? |
|
Added comment in the PR review. It has not been addressed yet |
abhigyanghosh30
requested changes
Nov 25, 2024
| @@ -268,7 +268,7 @@ def cred_schedule( | |||
| f"{data['date']}T{data['time']}", "%Y-%m-%dT%H:%M" | |||
| ) | |||
| starts_at = tz_info.localize(scheduled_time) | |||
| contract_item_id = data["contract_item_id"] | |||
| contract_item_id = flask.request.args.get("contractItemID") | |||
There was a problem hiding this comment.
Should not be used to get data from POST requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
./run serveordotrunIssue / Card
Fixes WD-16047
Help
QA steps - Commit guidelines