-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Build /20-04 page #14559
feat: Build /20-04 page #14559
Conversation
Thanks @petesfrench ! :) A few comments from me: For the hero section section:
For the "Expanded Security Maintenance (ESM) for 20.04 LTS" section:
For the "What do you get with Ubuntu Pro for 20.04 LTS?" section:
For the "What customers say about ESM" section:
For the blog section:
And a quick question about tables on smaller screens: |
Looks great, ty @petesfrench ! I'll +1, but just wanted to ask if you could add the line break after "support" in the h2 of the hero? |
templates/20-04/index.html
Outdated
|
||
{%- if slot == 'heading_link' -%} | ||
<div class="p-section--shallow"> | ||
<a href="https://ubuntu.com/engage">All the success stories ›</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find this link on the copy doc, is it missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattea-turic Where is this supposed to link to? I just guessed with this link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petesfrench Took from UX wireframe, I see now it wasn't in the copydoc, so I think you're good to just delete it. I'll just double-check with Sophie
dda7721
to
d65b452
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thanks, +1 with some minor suggestions
missing alt= for the images |
I pointed it out to PM, but they have two copydocs and right now the one linked here is not the correct one. This is the correct one and is the one linked in the JIra issue - https://docs.google.com/document/d/1lzxAL9Wt24m5-p5qG9y190rOg3FY5zVdKLYLlBoBcLU/edit?tab=t.0 |
All the images have |
Done
_latest_news_strip.html
4.18.4
QA
_latest_news_strip.html
is implemented and ensure there is no differenceIssue / Card
Fixes https://warthogs.atlassian.net/browse/WD-17287