-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WD-16838 Rebranded /landscape/managed page #14580
WD-16838 Rebranded /landscape/managed page #14580
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature-rebrand-landscape #14580 +/- ##
============================================================
Coverage ? 69.64%
============================================================
Files ? 120
Lines ? 3419
Branches ? 1174
============================================================
Hits ? 2381
Misses ? 1013
Partials ? 25 |
Thanks @muhammad-ali-pk ! Only a couple of things from me:
|
Thanks @mattea-turic! All done! |
Thanks @muhammad-ali-pk, this looks great! Just a few quick comments:
|
@eliman11 Thanks Elaine. All done! |
|
@Sophie-32 Thanks Sophie! I have added the suggestion. |
1d6a072
to
42a7ad0
Compare
@muhammad-ali-pk - thanks for flagging. Yes for logos our guidance is to "se the brand name (for example, ‘Microsoft Azure,’ not ‘Microsoft Azure logo’). Use empty state if the company name is used in the title or a link label." |
Hey @muhammad-ali-pk , just noticed you've got an extra asterix undet the table in "Pricing that is clear and transparent" I'll +1 for design, though! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Good Work!
Left minor comments
LGTM! Please do that one change and it should be good to merge |
0499cb8
into
canonical:feature-rebrand-landscape
* rebrand /landscape * updated quote image * review design changes * review changes * WD-16842 Redirect /landscape/install to Docs (#14582) * Remove /landscape/install and redirect to docs * Point install to docs in navigation --------- Co-authored-by: Muhammad Ali <[email protected]> * WD-16840 Rebranded /landscape/pricing page (#14581) * Rebrand /landscape/pricing 1. Rename pricing to compare 2. Add redirect from pricing to compare * Updated asset * Applied UX review suggestions --------- Co-authored-by: Muhammad Ali <[email protected]> * WD-16838 Rebranded /landscape/managed page (#14580) * Rebranded /landscape/managed page * Applied design review suggestions * Triggering deployment * Applied UX review suggestions * Added a link * Applied code review suggestions * Enclose image module in a wrapper * Removed unnecessary spacing --------- Co-authored-by: Muhammad Ali <[email protected]> * WD-16836 Rebranded /landscape/features page (#14576) * Rebranded /landscape/features page * Applied UX review suggestions * Applied design review changes * lazy load images not in viewport * Code review changes * Added different assets for different screen sizes --------- Co-authored-by: Muhammad Ali <[email protected]> --------- Co-authored-by: immortalcodes <[email protected]> Co-authored-by: Madhur Jain <[email protected]> Co-authored-by: Muhammad Ali <[email protected]>
Done
QA
Issue / Card
Fixes #WD-16838