Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-16838 Rebranded /landscape/managed page #14580

Conversation

muhammad-ali-pk
Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk commented Dec 17, 2024

Done

  • Rebranded page

QA

Issue / Card

Fixes #WD-16838

@webteam-app
Copy link

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature-rebrand-landscape@32026ad). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             feature-rebrand-landscape   #14580   +/-   ##
============================================================
  Coverage                             ?   69.64%           
============================================================
  Files                                ?      120           
  Lines                                ?     3419           
  Branches                             ?     1174           
============================================================
  Hits                                 ?     2381           
  Misses                               ?     1013           
  Partials                             ?       25           

@mattea-turic
Copy link
Collaborator

mattea-turic commented Dec 17, 2024

Thanks @muhammad-ali-pk ! Only a couple of things from me:

  • For the section "Bring your own identity and access management platform", the image should have the grey background – I forgot to apply that back on figma after exporting the image, so mb!
  • I'd also say to hide that image on smaller screens as it's there's too much detail for it to work unless you're viewing on a desktop (or large tablet)
  • You forgot this section: "Mirror Ubuntu repositories, and distribute software internally"

@muhammad-ali-pk
Copy link
Contributor Author

Thanks @mattea-turic! All done!
Though strange, that section feeling like déjà vu.

@eliman11
Copy link

eliman11 commented Dec 17, 2024

Thanks @muhammad-ali-pk, this looks great! Just a few quick comments:

  • Link asterisk(*) in the pricing block to the live Managed Apps page instead of the copydoc for that page, also added as a suggestion in the copydoc - https://ubuntu.com/managed/apps
  • Change the [Get started with a free quote and architecture assessment ›] and the [Contact us about your unique requirements ›] CTAs to link to the contact form instead of the copydoc
  • Could you also add alt text to logos in the logo cloud using the titles on the copydoc?

@muhammad-ali-pk
Copy link
Contributor Author

muhammad-ali-pk commented Dec 18, 2024

@eliman11 Thanks Elaine. All done!

@Sophie-32
Copy link

Sophie-32 commented Dec 18, 2024

  1. All images are decorative, should have alt=""
  2. Added a small item in suggested mode in the copydoc and tagged @muhammad-ali-pk in the Design as well

@muhammad-ali-pk
Copy link
Contributor Author

@Sophie-32 Thanks Sophie! I have added the suggestion.
Just a tiny confusion on the images. All the images except the brand logos for cloud are decorative and have alt="". However, shouldn't the logos actually have the alt text, especially since brand logos usually don't count as decorative, and also, someone using Text to Speech would be needing those alt texts for the logos?

@muhammad-ali-pk muhammad-ali-pk force-pushed the landscape-managed-rebrand branch from 1d6a072 to 42a7ad0 Compare December 19, 2024 05:51
@Sophie-32
Copy link

@muhammad-ali-pk - thanks for flagging. Yes for logos our guidance is to "se the brand name (for example, ‘Microsoft Azure,’ not ‘Microsoft Azure logo’). Use empty state if the company name is used in the title or a link label."

@mattea-turic
Copy link
Collaborator

Hey @muhammad-ali-pk , just noticed you've got an extra asterix undet the table in "Pricing that is clear and transparent"

I'll +1 for design, though!

@immortalcodes
Copy link
Member

image

We can remove the p-section and p-section--shallow here and just add p-section

@immortalcodes
Copy link
Member

image

Shallow padding here

Copy link
Member

@immortalcodes immortalcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Good Work!
Left minor comments

templates/landscape/managed.html Outdated Show resolved Hide resolved
templates/landscape/managed.html Outdated Show resolved Hide resolved
templates/landscape/managed.html Show resolved Hide resolved
templates/landscape/managed.html Outdated Show resolved Hide resolved
@immortalcodes
Copy link
Member

image

Now we have a shallow padding here so we don't need u-sv4

@immortalcodes
Copy link
Member

LGTM! Please do that one change and it should be good to merge

@muhammad-ali-pk muhammad-ali-pk merged commit 0499cb8 into canonical:feature-rebrand-landscape Dec 20, 2024
12 checks passed
@muhammad-ali-pk muhammad-ali-pk deleted the landscape-managed-rebrand branch December 20, 2024 11:59
muhammad-ali-pk added a commit that referenced this pull request Dec 20, 2024
* rebrand /landscape

* updated quote image

* review design changes

* review changes

* WD-16842 Redirect /landscape/install to Docs (#14582)

* Remove /landscape/install and redirect to docs

* Point install to docs in  navigation

---------

Co-authored-by: Muhammad Ali <[email protected]>

* WD-16840 Rebranded /landscape/pricing page (#14581)

* Rebrand /landscape/pricing

1. Rename pricing to compare
2. Add redirect from pricing to compare

* Updated asset

* Applied UX review suggestions

---------

Co-authored-by: Muhammad Ali <[email protected]>

* WD-16838 Rebranded /landscape/managed page (#14580)

* Rebranded  /landscape/managed page

* Applied design review suggestions

* Triggering deployment

* Applied UX review suggestions

* Added a link

* Applied code review suggestions

* Enclose image module in a wrapper

* Removed unnecessary spacing

---------

Co-authored-by: Muhammad Ali <[email protected]>

* WD-16836 Rebranded /landscape/features page (#14576)

* Rebranded /landscape/features page

* Applied UX review suggestions

* Applied design review changes

* lazy load images not in viewport

* Code review changes

* Added different assets for different screen sizes

---------

Co-authored-by: Muhammad Ali <[email protected]>

---------

Co-authored-by: immortalcodes <[email protected]>
Co-authored-by: Madhur Jain <[email protected]>
Co-authored-by: Muhammad Ali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants