-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Pageheader,Tearsheet,Notifications): resolves CSP violations #6340
Open
AlexanderMelox
wants to merge
24
commits into
carbon-design-system:main
Choose a base branch
from
AlexanderMelox:6190--csp-spreadsheet-tearsheet-notifications-page-header
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(Pageheader,Tearsheet,Notifications): resolves CSP violations #6340
AlexanderMelox
wants to merge
24
commits into
carbon-design-system:main
from
AlexanderMelox:6190--csp-spreadsheet-tearsheet-notifications-page-header
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderMelox
requested review from
elycheea,
matthewgallo,
kennylam and
a team
as code owners
October 31, 2024 15:46
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AlexanderMelox
changed the title
6190 csp spreadsheet tearsheet notifications page header
fix(Pageheader,Tearsheet,Notifications): resolves CSP violations
Oct 31, 2024
Interesting, thank you! Matt to the rescue 🛟 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6340 +/- ##
==========================================
+ Coverage 79.61% 79.62% +0.01%
==========================================
Files 394 394
Lines 12858 12870 +12
Branches 4263 4266 +3
==========================================
+ Hits 10237 10248 +11
- Misses 2621 2622 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6190
This PR resolves CSP violation issues
What did you change?
Moved inline styles to
useIsomorphicEffect
How did you test and verify your work?
Storybook