[ADP-3350] Change lightSync to use Read.ChainPoint
#4530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3350/read-chainpoint
branch
14 times, most recently
from
bc730fd to
e805055
Compare
HeinrichApfelmus
changed the base branch from
master
to
HeinrichApfelmus/ADP-3350/chainpoint
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3350/read-chainpoint
branch
7 times, most recently
from
bbe8777 to
33dc2be
Compare
HeinrichApfelmus
changed the base branch from
master
to
HeinrichApfelmus/ADP-3350/read-chaintip
Base automatically changed from
HeinrichApfelmus/ADP-3350/read-chaintip
to
master
April 18, 2024 13:03
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3350/read-chainpoint
branch
from
33dc2be to
2504a29
Compare
HeinrichApfelmus
changed the base branch from
master
to
HeinrichApfelmus/ADP-3350/read-chainsync-tip
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3350/read-chainsync-tip
branch
from
0e48ea8 to
96921ea
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3350/read-chainpoint
branch
from
2504a29 to
fce4c55
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3350/read-chainpoint
branch
from
fce4c55 to
a9e5bc7
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3350/read-chainsync-tip
branch
from
96921ea to
a4bca66
Compare
Base automatically changed from
HeinrichApfelmus/ADP-3350/read-chainsync-tip
to
master
April 19, 2024 19:04
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3350/read-chainpoint
branch
from
a9e5bc7 to
d4b5c51
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3350/read-chainpoint
branch
from
d4b5c51 to
7474300
Compare
HeinrichApfelmus
changed the title
Read.ChainPoint and use it in network layerlightSync to use Read.ChainPoint
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3350/read-chainpoint
branch
from
7474300 to
b0d58e7
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3350/read-chainpoint
branch
from
b0d58e7 to
2ef05e5
Compare
| compareSlot pt1 pt2 = compare (toOrdered pt1) (toOrdered pt2) | ||
| where | ||
| toOrdered :: Read.ChainPoint -> Integer | ||
| toOrdered Read.GenesisPoint = -1 |
There was a problem hiding this comment.
with 0 it would not work?
There was a problem hiding this comment.
Yes. The points GenesisPoint and Read.BlockPoint (Read.SlotNo 0) are different.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
This pull request changes the `lightSync` function to use the data type `ChainPoint` from the `Cardano.Wallet.Read` hierarchy. ### Comments * `lightSync` still uses the legacy `BlockHeader` type from `primitive` for now. * The goal is to eventually remove the legacy `primitive` types. ### Issue Number ADP-3350
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3350/read-chainpoint
branch
from
2ef05e5 to
f9faccc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the
lightSyncfunction to use the data typeChainPointfrom theCardano.Wallet.Readhierarchy.Comments
lightSyncstill uses the legacyBlockHeadertype fromprimitivefor now.primitivetypes.Issue Number
ADP-3350