Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3368] Add linux E2E step to release pipeline #4654

Merged
merged 1 commit into from
Jun 28, 2024
Merged

[ADP-3368] Add linux E2E step to release pipeline #4654

merged 1 commit into from
Jun 28, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jun 27, 2024 •
edited
Loading

This PR enables linux E2E tests in the release pipeline, https://buildkite.com/cardano-foundation/cardano-wallet-release/builds/150

  • Add node socket arguments to work around socket name length limitation
  • Add a shell script that captures the GHA steps of the linux E2E
  • Add a bit of logs to the Rakefile
  • Add a step to the release pipeline

@paolino paolino added CI CI related Release labels Jun 27, 2024
@paolino paolino self-assigned this Jun 27, 2024
@paolino paolino changed the title Add the "Run linux E2e" step [ADP-3368] Add linux E2E step to release pipeline Jun 27, 2024
HeinrichApfelmus
HeinrichApfelmus approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😊

Before merging, could you:

  • Rebase this branch on master? Somehow, this branch sits on top of a completely parallel thing.
  • Keep the .gpg file? 😅

scripts/buildkite/release/linux-e2e.sh Outdated Show resolved Hide resolved
test/e2e/fixtures/fixture_wallets.json.gpg Outdated Show resolved Hide resolved
paweljakubas
paweljakubas approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable modulo gpg file retention

@paolino paolino force-pushed the paolino/ADP-3368/move-linux-E2E-test-to-buildkite branch 3 times, most recently from c256263 to 1977c8d Compare June 28, 2024 13:47
@paolino paolino enabled auto-merge June 28, 2024 13:47
@paolino paolino force-pushed the paolino/ADP-3368/move-linux-E2E-test-to-buildkite branch from 1977c8d to 6d92067 Compare June 28, 2024 13:48
@paolino paolino disabled auto-merge June 28, 2024 13:49
@paolino paolino enabled auto-merge June 28, 2024 13:52
@paolino paolino added this pull request to the merge queue Jun 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 28, 2024
@paolino paolino added this pull request to the merge queue Jun 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 28, 2024
@paolino paolino added this pull request to the merge queue Jun 28, 2024
Merged via the queue into master with commit 3079055 Jun 28, 2024
4 checks passed
@paolino paolino deleted the paolino/ADP-3368/move-linux-E2E-test-to-buildkite branch June 28, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
CI CI related Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paolino @HeinrichApfelmus @paweljakubas