Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3389] Collect history of benchmark results in the CI of the release candidate #4688

Merged
merged 10 commits into from
Jul 24, 2024
Merged

[ADP-3389] Collect history of benchmark results in the CI of the release candidate #4688

merged 10 commits into from
Jul 24, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jul 18, 2024 •
edited
Loading

  • Add buildkite client library that support retrieving builds by branch and artifacts
  • Collect benchmark CSV from buildkite
  • Produce a csv file containing the historical data
  • Produce a chart for every metrics
  • Add a step in the pipeline of the release-candidate build that produce an artifact with the historical data and the 289 charts

ADP-3389

@paolino paolino added CI CI related Release labels Jul 18, 2024
@paolino paolino self-assigned this Jul 18, 2024
@paolino paolino force-pushed the paolino/ADP-3389/add-builkdkite-package branch 6 times, most recently from 1f17046 to 571cb00 Compare July 23, 2024 07:26
@paolino paolino force-pushed the paolino/ADP-3389/add-builkdkite-package branch 2 times, most recently from 521ffff to b6e7db8 Compare July 23, 2024 11:47
@paolino paolino force-pushed the paolino/ADP-3389/add-builkdkite-package branch 11 times, most recently from d466dca to ae62ec9 Compare July 23, 2024 15:29
@paolino paolino marked this pull request as ready for review July 23, 2024 15:29
@paolino paolino requested a review from HeinrichApfelmus July 23, 2024 15:29
@paolino paolino changed the title [ADP-3389] Collect benchmark results [ADP-3389] Collect history of benchmark results in the CI of the release candidate Jul 23, 2024
HeinrichApfelmus
HeinrichApfelmus approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😊

A couple of comments regarding HarmonizedRow, and the name Units — but since this is utility code, happy to merge as is as well.

lib/benchmarks/src/Cardano/Wallet/Benchmarks/History.hs Outdated Show resolved Hide resolved
lib/benchmarks/src/Cardano/Wallet/Benchmarks/Collect.hs Outdated Show resolved Hide resolved
lib/benchmarks/src/Cardano/Wallet/Benchmarks/History.hs Show resolved Hide resolved
lib/benchmarks/src/Cardano/Wallet/Benchmarks/History.hs Outdated Show resolved Hide resolved
@paolino paolino force-pushed the paolino/ADP-3389/add-builkdkite-package branch from ae62ec9 to cff494c Compare July 24, 2024 11:36
@paolino paolino enabled auto-merge July 24, 2024 11:36
@paolino paolino added this pull request to the merge queue Jul 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 24, 2024
@paolino paolino added this pull request to the merge queue Jul 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 24, 2024
@paolino paolino added this pull request to the merge queue Jul 24, 2024
Merged via the queue into master with commit dbc8a44 Jul 24, 2024
22 checks passed
@paolino paolino deleted the paolino/ADP-3389/add-builkdkite-package branch July 24, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
CI CI related Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus