[ADP-2565] Improve performance of insertMany with prepared statement
#4699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
approved these changes
Jul 25, 2024
| ReaderT $ \conn -> do | ||
| -- The 'query' string contains '?' which will be substituted | ||
| -- for the values in the row. | ||
| let query = fst $ renderStmt $ Stmt.insertOne proxy |
There was a problem hiding this comment.
If there shouldn't be any bindings, then perhaps
Suggested change
| let query = fst $ renderStmt $ Stmt.insertOne proxy | |
| let (query, _noBindings) = $ renderStmt $ Stmt.insertOne proxy |
unless we even want it to crash if there are?
Suggested change
| let query = fst $ renderStmt $ Stmt.insertOne proxy | |
| let (query, []) = $ renderStmt $ Stmt.insertOne proxy |
There was a problem hiding this comment.
_noBindings sounds good to me.
I don't think that let (query, []) = … actually crashes — let bindings introduce irrefutable pattern.
Anviking
reviewed
Jul 25, 2024
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-2565/sql-insertMany
branch
from
2bea6ec to
5206b45
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-2565/sql-insertMany
branch
from
5206b45 to
c638f11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the performance of
insertManyby using a single prepared statement and setting new parameters multiple times.Comments
Demo.Databaseprovides a basic functionality check.Issue Number
ADP-2565