Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3421] Ruby E2E tests: Skip test with two cosigners #4766

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[ADP-3421] Ruby E2E tests: Skip test with two cosigners #4766

merged 1 commit into from
Sep 3, 2024

Conversation

HeinrichApfelmus
Copy link
Contributor

This pull requests makes happy coins sad again. Well, actually this pull request uses skip instead of pending for the E2E test on shared wallets. It turns out that pending expects failure, while skip ignores the test entirely.

Issue Number

ADP-3421

@HeinrichApfelmus HeinrichApfelmus self-assigned this Sep 3, 2024
@HeinrichApfelmus HeinrichApfelmus merged commit f5fa6bb into master Sep 3, 2024
20 of 24 checks passed
@HeinrichApfelmus HeinrichApfelmus deleted the HeinrichApfelmus/ADP-3421/ruby-pending branch September 3, 2024 15:29
@HeinrichApfelmus
Copy link
Contributor Author

Force-merging, because

  • We need this soon
  • These changes do not affect the functional code, only the tests
  • Testing the tests has a roundtrip time of ~1h
  • The change is so small that it should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolino paolino Awaiting requested review from paolino

Assignees

@HeinrichApfelmus HeinrichApfelmus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HeinrichApfelmus