[ADP-3479] Add deposit wallet payment page #4837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolino
force-pushed
the
paolino/ADP-3479/add-payment-page
branch
from
608ad20 to
fb9289a
Compare
Base automatically changed from
paolino/ADP-3479/add-address-codec-to-deposit-wallet
to
master
November 10, 2024 08:57
paolino
force-pushed
the
paolino/ADP-3479/add-payment-page
branch
14 times, most recently
from
6b4010d to
28ab6b0
Compare
paolino
changed the base branch from
master
to
paolino/ADP-3479/split-pure-module
paolino
force-pushed
the
paolino/ADP-3479/add-payment-page
branch
2 times, most recently
from
5e4340b to
bb3d325
Compare
Base automatically changed from
paolino/ADP-3479/split-pure-module
to
master
November 14, 2024 14:33
paolino
force-pushed
the
paolino/ADP-3479/add-payment-page
branch
7 times, most recently
from
599efb3 to
69c34dc
Compare
paolino
force-pushed
the
paolino/ADP-3479/fix-private-key-creation
branch
2 times, most recently
from
4ef48d6 to
0200b5a
Compare
paolino
force-pushed
the
paolino/ADP-3479/add-payment-page
branch
2 times, most recently
from
6a21e81 to
bf9a4a7
Compare
paolino
force-pushed
the
paolino/ADP-3479/fix-private-key-creation
branch
2 times, most recently
from
2876118 to
925cd15
Compare
paolino
force-pushed
the
paolino/ADP-3479/add-payment-page
branch
from
bf9a4a7 to
bb8e1d7
Compare
Base automatically changed from
paolino/ADP-3479/fix-private-key-creation
to
master
December 6, 2024 10:37
Anviking
reviewed
Dec 9, 2024
|
|
||
| showLovelaceAsAda :: Integral a => a -> String | ||
| showLovelaceAsAda c = | ||
| showFFloatAlt @Double (Just 2) (fromIntegral c / 1_000_000) "" |
There was a problem hiding this comment.
It seems odd that I can enter 10.000001 as payment and not see the result:
Suggested change
| showFFloatAlt @Double (Just 2) (fromIntegral c / 1_000_000) "" | |
| showFFloatAlt @Double (Just 6) (fromIntegral c / 1_000_000) "" |
There was a problem hiding this comment.
Also, I wonder if the Double precision could be problematic...
There was a problem hiding this comment.
The maximum amount of Lovelace one can define is bounded to be a Word64 if I am not mistaken, which should be representable as Double with some loss of precision. Do we want an exact representation? If so then this code is incorrect. If we don't really care which I think we don't because this UI will probably not go into production as is, then this is fine.
abailly
approved these changes
Dec 9, 2024
abailly
force-pushed
the
paolino/ADP-3479/add-payment-page
branch
from
5718b41 to
8f6fd06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boxesto get a better readabilityADP-3479